[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

Berker Peksag added the comment: New changeset cc96231f0a59cc7393943064800ecb6c18892662 by Erlend Egeberg Aasland in branch 'master': bpo-43249: Improve scoping in _pysqlite_fetch_one_row() (GH-24565) https://github.com/python/cpython/commit/cc96231f0a59cc7393943064800ecb6c18892662

[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

Change by Erlend Egeberg Aasland : -- pull_requests: +23346 pull_request: https://github.com/python/cpython/pull/24565 ___ Python tracker ___

[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

Berker Peksag added the comment: New changeset 47feb1feb28631b6647699b7633109aa85340966 by Erlend Egeberg Aasland in branch 'master': bpo-43249: sqlite3_column_bytes() must follow sqlite_column_blob() (GH-24562)

[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +23343 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24562 ___ Python tracker

[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

Erlend Egeberg Aasland added the comment: > Sounds good to me but I'd say designing APIs relying on call order is bad too > :) Yes, it's too easy to mess up things with this part of the SQLite API :) I'll throw up a PR. BTW (small digression): I really want to refactor

[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

Berker Peksag added the comment: Good catch! Sounds good to me but I'd say designing APIs relying on call order is bad too :) -- ___ Python tracker ___

[issue43249] sqlite3_column_bytes() should be called after sqlite3_column_blob()

New submission from Erlend Egeberg Aasland : sqlite3_column_bytes() should be called _after_ sqlite3_column_blob(). There two calls to sqlite3_column_blob() are both preceeded by calls to sqlite3_column_bytes(). Currently it does not do any harm, but it is bad API usage. I suggest to fix