[issue43269] [sqlite3] Clean up function scoping

Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43269] [sqlite3] Clean up function scoping

Berker Peksag added the comment: New changeset 38b6c2acd4bba666bd64779c42b9d91cbee19274 by Erlend Egeberg Aasland in branch 'master': bpo-43269: Remove redundant extern keywords (GH-24605) https://github.com/python/cpython/commit/38b6c2acd4bba666bd64779c42b9d91cbee19274 --

[issue43269] [sqlite3] Clean up function scoping

Change by Erlend Egeberg Aasland : -- pull_requests: +23383 pull_request: https://github.com/python/cpython/pull/24605 ___ Python tracker ___

[issue43269] [sqlite3] Clean up function scoping

Erlend Egeberg Aasland added the comment: Serhiy also mentioned that marking functions definitions with the extern keyword is not very common in the CPython source base. https://github.com/python/cpython/pull/24578#discussion_r579506678 I suggest cleaning up those as well, while we're at

[issue43269] [sqlite3] Clean up function scoping

Berker Peksag added the comment: New changeset bf838a6e7eec2063a17c7c33dfa94afeef116f36 by Erlend Egeberg Aasland in branch 'master': bpo-43269: Clean up sqlite3 file scope (GH-24578) https://github.com/python/cpython/commit/bf838a6e7eec2063a17c7c33dfa94afeef116f36 --

[issue43269] [sqlite3] Clean up function scoping

Erlend Egeberg Aasland added the comment: Ref. https://github.com/python/cpython/pull/24569#issuecomment-782014177, Berker. -- ___ Python tracker ___

[issue43269] [sqlite3] Clean up function scoping

Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +23357 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24578 ___ Python tracker

[issue43269] [sqlite3] Clean up function scoping

New submission from Erlend Egeberg Aasland : There's a lot of file scoped functions without the static storage-class specifier. All file local functions should have the static storage-class specifier. -- components: Library (Lib) messages: 387310 nosy: berker.peksag, erlendaasland