[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Change by neonene : -- nosy: +neonene, pablogsal nosy_count: 8.0 -> 10.0 pull_requests: +30112 pull_request: https://github.com/python/cpython/pull/32023 ___ Python tracker

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

STINNER Victor added the comment: Thanks for the fix David Bolen ;-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Guido van Rossum added the comment: Thanks for all your research and the PR! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

David Bolen added the comment: The win10 buildbot is green again, so I think this can be closed. -- ___ Python tracker ___ ___

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Guido van Rossum added the comment: New changeset 131d5516409791b170b09a6ef8ed8463c9b09015 by db3l in branch 'master': bpo-43271: Re-enable ceval.c optimizations for Windows debug builds (GH-24739) https://github.com/python/cpython/commit/131d5516409791b170b09a6ef8ed8463c9b09015 --

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Change by David Bolen : -- keywords: +patch pull_requests: +23510 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24739 ___ Python tracker ___

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

David Bolen added the comment: Yes, that was the idea (revert the PyDEBUG condition only); it sounds like everyone is on the same page. I've been doing buildbot duties only for a while (no code contributions since long before the current process), so there may be a short delay while I

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Steve Dower added the comment: Hmm, yeah, it seems like the debug-specific definition has gone. Wonder when that happened. In that case, go ahead and revert, but I'd suggest doing it by just removing the new Py_DEBUG condition rather than undoing all the changes. Should be nothing wrong

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Steve Dower added the comment: We already have a separate recursion limit for debug builds on Windows, so it's probably best all around to reduce that (if it's only recursion tests that are failing). That way, we won't forget to fix up debugging later if/when we fix recursion. --

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

David Bolen added the comment: Steve, where is that configured? If reducing that further would resolve the crashes while retaining ceval debugging, maybe that's a reasonable trade-off, though based on my testing, reverting still seems simpler. Right now the debug build on the buildbot

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Mark Shannon added the comment: PEP 651 would prevent any crashes, although some of the tests might still fail with a StackOverflowException, if they weren't expecting a RecursionError. -- ___ Python tracker

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Guido van Rossum added the comment: Thanks! That's new info, at least, it wasn't clear to me from Victor's original comment that this was for a debug build (even though as you say it can be deduced from context). Do you feel like submitting a PR along the lines I suggested? --

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

David Bolen added the comment: I hadn't tested release mode earlier, since the commit only removed the pragma in debug builds, but I just built a release build with the commit in place on the worker and it seems fine. So barring stack changes (enlarging or improving usage) it appears the

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Guido van Rossum added the comment: Thanks David! So the crash only happens in debug mode? PEP 651 promises to take reduce the C stack usage in the future. Therefore, I would be okay with rolling this back for the time being. If we do roll it back, maybe add a comment to ceval.c explaining

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

David Bolen added the comment: I don't think it's actually any change in ceval per se, or any new buffers, just how the compiler code generation has changed due to this commit. Based on some local testing, the triggering issue is the exclusion of the optimization pragma entirely in debug

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Change by Pablo Galindo Salgado : -- priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Change by Guido van Rossum : -- nosy: +Mark.Shannon, gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

STINNER Victor added the comment: If someone wants to measure the stack memory usage per function call, _testcapi.stack_pointer() can be used: see bpo-30866. -- ___ Python tracker

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

Steve Dower added the comment: Looks like someone increased the size of locals in the ceval functions. If any new buffers have been added recently, moving the processing into a helper function or using a single buffer instead of allocating them in separate if/case blocks can help reduce it.

[issue43271] AMD64 Windows10 3.x crash with Windows fatal exception: stack overflow

New submission from STINNER Victor : AMD64 Windows10 3.x, build 856: https://buildbot.python.org/all/#/builders/146/builds/856 17 tests failed: test_exceptions test_fileio test_io test_isinstance test_json test_lib2to3 test_logging test_pickle test_pickletools test_plistlib