[issue43296] [sqlite3] Fix sqlite3_value_blob() usage

2021-04-14 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: Thanks, Berker! I'll add separate issues for sqlite3_value_text() and the missing PyTuple_SetItem() error checks. -- ___ Python tracker

[issue43296] [sqlite3] Fix sqlite3_value_blob() usage

2021-04-14 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43296] [sqlite3] Fix sqlite3_value_blob() usage

2021-04-14 Thread Berker Peksag
Berker Peksag added the comment: New changeset 5cb601f956886b32641f818b5da347cc86a43db2 by Erlend Egeberg Aasland in branch 'master': bpo-43296: Handle sqlite3_value_blob() errors (GH-24674) https://github.com/python/cpython/commit/5cb601f956886b32641f818b5da347cc86a43db2 --

[issue43296] [sqlite3] Fix sqlite3_value_blob() usage

2021-02-28 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +23459 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24674 ___ Python tracker

[issue43296] [sqlite3] Fix sqlite3_value_blob() usage

2021-02-26 Thread Erlend Egeberg Aasland
Erlend Egeberg Aasland added the comment: > If sqlite3_value_blob() returns NULL, we should check if sqlite3_errcode() > equals SQLITE_NOMEM and raise MemoryError if it does. This also applies to sqlite3_value_text(). It also applies to sqlite3_value_bytes() if a conversion takes place. We

[issue43296] [sqlite3] Fix sqlite3_value_blob() usage

2021-02-26 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- title: [sqlite3] sqlite3_value_bytes() should be called after sqlite3_value_blob() -> [sqlite3] Fix sqlite3_value_blob() usage ___ Python tracker