[issue43354] xmlrpc.client: Fault.faultCode erroneously documented to be a string, should be int

Jürgen Gmach added the comment: This was merged already. I did not know I have to manually close the issue, but here we go! -- stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue43354] xmlrpc.client: Fault.faultCode erroneously documented to be a string, should be int

miss-islington added the comment: New changeset 027b6699276ed8d9f68425697ac89bf61e54e6b9 by Jürgen Gmach in branch 'master': bpo-43354: xmlrpc: Fix type documentation for Fault.faultCode (GH-24707) https://github.com/python/cpython/commit/027b6699276ed8d9f68425697ac89bf61e54e6b9 --

[issue43354] xmlrpc.client: Fault.faultCode erroneously documented to be a string, should be int

Jürgen Gmach added the comment: The approved typeshed PR: https://github.com/python/typeshed/pull/5083 -- ___ Python tracker ___

[issue43354] xmlrpc.client: Fault.faultCode erroneously documented to be a string, should be int

Change by Jürgen Gmach : -- keywords: +patch pull_requests: +23482 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24707 ___ Python tracker ___

[issue43354] xmlrpc.client: Fault.faultCode erroneously documented to be a string, should be int

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43354] xmlrpc.client: Fault.faultCode erroneously documented to be a string, should be int

Paul Ganssle added the comment: The evidence you have here seems pretty compelling and this change seems straightforward enough. I don't see an expert listed here, but I'm happy to merge a docs PR fixing this. Probably a good idea to make a PR to typeshed in parallel, in case they have

[issue43354] xmlrpc.client: Fault.faultCode erroneously documented to be a string, should be int

New submission from Jürgen Gmach : I created a XMLRPC API (via Zope), which gets consumed by a C# application. C#'s XMLRPC lib expects an `int` for the `faultCode` but I currently return a string, as this is the type which is currently documented in the official docs