[issue43440] Enable rtree support in SQLite

Erlend Egeberg Aasland added the comment: I've opened bpo-43454 for R*Tree callbacks. -- ___ Python tracker ___ ___

[issue43440] Enable rtree support in SQLite

Erlend Egeberg Aasland added the comment: Anytime :) I'll create an issue for rtree callbacks. -- ___ Python tracker ___ ___

[issue43440] Enable rtree support in SQLite

Steve Dower added the comment: Perfect, thanks! Callbacks are a bigger ask, but I don't have any fundamental opposition to them. Probably worth opening a new issue, as it'll affect all platforms (I assume). And yeah, the setup.py in the CPython repo doesn't impact any of the Windows build

[issue43440] Enable rtree support in SQLite

Steve Dower added the comment: New changeset 31818e98d3b845d815e9caf2a3d330341bdc1b33 by Erlend Egeberg Aasland in branch 'master': bpo-43440 : Enable SQLite R*Tree support for windows builds (GH-24797) https://github.com/python/cpython/commit/31818e98d3b845d815e9caf2a3d330341bdc1b33

[issue43440] Enable rtree support in SQLite

Erlend Egeberg Aasland added the comment: > does compile options set in setup.py propagate to the Windows build, or do we > need to set it both places? Er, forget it. setup.py is of course only used to build the sqlite3 module, not sqlite3. --

[issue43440] Enable rtree support in SQLite

Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +23565 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24797 ___ Python tracker

[issue43440] Enable rtree support in SQLite

Erlend Egeberg Aasland added the comment: We should also consider adding support for R*Tree query callbacks using sqlite3_rtree_query_callback() for SQLite >= 3.8.5, and sqlite3_rtree_geometry_callback() for older versions. -- ___ Python tracker

[issue43440] Enable rtree support in SQLite

Erlend Egeberg Aasland added the comment: > does compile options set in setup.py propagate to the Windows build, or do we > need to set it both places? Seems like it doesn't; correct me if I'm wrong. PR coming up. -- ___ Python tracker

[issue43440] Enable rtree support in SQLite

Erlend Egeberg Aasland added the comment: Actually, the macOS build already builds with R*Tree support enabled, but it is missing from PCbuild/sqlite3.vcxproj. I'm not very familiar with the Windows build; does compile options set in setup.py propagate to the Windows build, or do we need to

[issue43440] Enable rtree support in SQLite

Erlend Egeberg Aasland added the comment: I can put up a PR for it. I don’t see any reason not to enable it. -- ___ Python tracker ___

[issue43440] Enable rtree support in SQLite

Erlend Egeberg Aasland added the comment: Unless I’m mistaken, that’s enabled simply by compiling with SQLITE_ENABLE_RTREE defined. -- ___ Python tracker ___

[issue43440] Enable rtree support in SQLite

Change by Zachary Ware : -- nosy: +berker.peksag, erlendaasland ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue43440] Enable rtree support in SQLite

Change by Steve Dower : -- nosy: +ghaering ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43440] Enable rtree support in SQLite

New submission from Steve Dower : I heard [1] that rtree support would be very useful in SQLite. We should see whether enabling it is safe/easy/cheap and then do it. 1: https://twitter.com/Jamieallencook/status/1368221499794976775?s=20 -- components: Build, Library (Lib), Windows