[issue4347] Circular dependency causes SystemError when adding new syntax

Pablo Galindo Salgado added the comment: I think there is nothing missing now that the C version of pgen is gone. And parsetok is already rebuilt when gramminit.h changes: Python/compile.o Python/symtable.o Python/ast_unparse.o Python/ast.o Python/future.o Parser/parsetok.o:

[issue4347] Circular dependency causes SystemError when adding new syntax

Brett Cannon added the comment: Pablo, is this still an issue? -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list

[issue4347] Circular dependency causes SystemError when adding new syntax

Change by Brett Cannon : -- resolution: wont fix -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue4347] Circular dependency causes SystemError when adding new syntax

Brett Cannon added the comment: Ah, the fact parsetok.c gets compiled twice into different object files is the detail I was overlooking. Thanks for the clarification. -- ___ Python tracker

[issue4347] Circular dependency causes SystemError when adding new syntax

Martin Panter added the comment: I’m not sure I understand your questions Brett (Which tokenizer? What rebuilding?), but I will try to explain some relevant parts. My main goal is to add a makefile dependency of parsetok.o on $(GRAMMAR_H). In Python 3, that is easy, and (I realize now) my

[issue4347] Circular dependency causes SystemError when adding new syntax

Brett Cannon added the comment: So what does having the tokenizer not depend on pgen accomplish? Does it break a circular dependency where the tokenizer will get rebuilt with pgen before a full build starts? -- ___ Python tracker

[issue4347] Circular dependency causes SystemError when adding new syntax

Martin Panter added the comment: Equivalent patch for 2.7 -- Added file: http://bugs.python.org/file45576/graminit-dep.py2.patch ___ Python tracker ___

[issue4347] Circular dependency causes SystemError when adding new syntax

Martin Panter added the comment: Here is a patch for Python 3 implementing my idea. There is already code conditionally compiled out for the pgen build, so my patch just expands that to avoid the "graminit.h" include and derived functions. -- stage: needs patch -> patch review status:

[issue4347] Circular dependency causes SystemError when adding new syntax

Martin Panter added the comment: I occasionally get the following error, due to Parser/parsetok.o being older than Include/graminit.h. ./python -E -S -m sysconfig --generate-posix-vars ; if test $? -ne 0 ; then echo "generate-posix-vars failed" ; rm -f ./pybuilddir.txt ; exit 1 ; fi Could

[issue4347] Circular dependency causes SystemError when adding new syntax

Brett Cannon added the comment: Since this has been sitting here for two months as pending I'm closing as won't fix since mucking with the grammar is such a rarity and getting the build rules right is so complicated it isn't worth changing. -- resolution: - wont fix status: pending -

[issue4347] Circular dependency causes SystemError when adding new syntax

Brett Cannon added the comment: This still an issue? -- status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4347 ___ ___

[issue4347] Circular dependency causes SystemError when adding new syntax

Changes by Brett Cannon br...@python.org: -- assignee: brett.cannon - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4347 ___ ___ Python-bugs-list

[issue4347] Circular dependency causes SystemError when adding new syntax

Changes by Brett Cannon br...@python.org: -- priority: - normal stage: patch review - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4347 ___

[issue4347] Circular dependency causes SystemError when adding new syntax

Thomas Lee t...@vector-seven.com added the comment: This would appear to be another build quirk: Lib/symbol.py needs to be regenerated if Grammar/Grammar changes. Brett, do you think it would be okay for this file to be generated automatically as part of the build process? I can't think of any

[issue4347] Circular dependency causes SystemError when adding new syntax

Brett Cannon br...@python.org added the comment: On Mon, Feb 9, 2009 at 01:11, Thomas Lee rep...@bugs.python.org wrote: Thomas Lee t...@vector-seven.com added the comment: This would appear to be another build quirk: Lib/symbol.py needs to be regenerated if Grammar/Grammar changes. Brett,

[issue4347] Circular dependency causes SystemError when adding new syntax

Brett Cannon br...@python.org added the comment: So I finally got around to reviewing the patch and while it looks fine, I ended up with some failing tests: test_compiler test_quopri test_sys test_transformer. Do you know what is going on Thomas? This is after repeated make/make clean calls and

[issue4347] Circular dependency causes SystemError when adding new syntax

Thomas Lee t...@vector-seven.com added the comment: Brett, any feedback on this one? ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4347 ___ ___

[issue4347] Circular dependency causes SystemError when adding new syntax

Brett Cannon br...@python.org added the comment: I will take a look when I can. -- assignee: - brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4347 ___

[issue4347] Circular dependency causes SystemError when adding new syntax

Brett Cannon [EMAIL PROTECTED] added the comment: Because of all the patch includes a bunch of junk for generated files (any chance you can make a diff, Thomas, with only the stuff that really requires review?), I have not done a real review. But a quick look does show that the comment added to

[issue4347] Circular dependency causes SystemError when adding new syntax

Thomas Lee [EMAIL PROTECTED] added the comment: Thanks for the review Brett, apologies for the mess. I'm attaching two new patches -- one for review, the other containing the generated files. These differ very slightly from the original patch -- mainly just removing some stuff I don't think is

[issue4347] Circular dependency causes SystemError when adding new syntax

Thomas Lee [EMAIL PROTECTED] added the comment: And here's the patch for review. Added file: http://bugs.python.org/file12209/build-evilness-fix-03-review.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4347

[issue4347] Circular dependency causes SystemError when adding new syntax

Thomas Lee [EMAIL PROTECTED] added the comment: I mean pgen's dependency on graminit.h, not the parser's. :) ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4347 ___

[issue4347] Circular dependency causes SystemError when adding new syntax

Thomas Lee [EMAIL PROTECTED] added the comment: okay, so it turns out that putting rules in Grammar/Grammar before the top-level non-terminals breaks things in a different way. Attached is another (hopefully final and working) patch. Added file:

[issue4347] Circular dependency causes SystemError when adding new syntax

Thomas Lee [EMAIL PROTECTED] added the comment: Here's a new patch that I believe should fix this issue. It modifies Makefile.pre.in to include a few additional dependency declarations for source files that depend on Include/graminit.h and Include/Python-ast.h, as well as moving encoding_decl