[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

Steve Dower added the comment: New changeset e92d1106291e5a7d4970372478f2882056b7eb3a by Miss Islington (bot) in branch '3.8': bpo-43607: Fix urllib handling of Windows paths with \\?\ prefix (GH-25539) https://github.com/python/cpython/commit/e92d1106291e5a7d4970372478f2882056b7eb3a

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

miss-islington added the comment: New changeset 04bcfe001cdf6290cb78fa4884002e5301e14c93 by Miss Islington (bot) in branch '3.9': bpo-43607: Fix urllib handling of Windows paths with \\?\ prefix (GH-25539) https://github.com/python/cpython/commit/04bcfe001cdf6290cb78fa4884002e5301e14c93

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

Change by miss-islington : -- nosy: +miss-islington nosy_count: 6.0 -> 7.0 pull_requests: +24277 pull_request: https://github.com/python/cpython/pull/25558 ___ Python tracker

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

Steve Dower added the comment: New changeset 3513d55a617012002c3f82dbf3cec7ec1abd7090 by Steve Dower in branch 'master': bpo-43607: Fix urllib handling of Windows paths with \\?\ prefix (GH-25539) https://github.com/python/cpython/commit/3513d55a617012002c3f82dbf3cec7ec1abd7090 --

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

Change by miss-islington : -- pull_requests: +24278 pull_request: https://github.com/python/cpython/pull/25559 ___ Python tracker ___

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

Change by Steve Dower : -- assignee: -> steve.dower versions: +Python 3.10, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

Change by Steve Dower : -- keywords: +patch pull_requests: +24259 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25539 ___ Python tracker ___

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

D Levine added the comment: I think that would make the most sense, yes. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

Eryk Sun added the comment: > I suppose the most reasonable behavior is to strip out the "\\?\" before > attempting the conversion as the path is sensible and parsable without Okay, so you're not looking to preserve the fact that it's a \\?\ verbatim path in the URI. You just want to

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

D Levine added the comment: I really meant 255 characters not 256 because I was leaving three for ":/". I suppose the most reasonable behavior is to strip out the "\\?\" before attempting the conversion as the path is sensible and parsable without that, as opposed to the current behavior

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

Eryk Sun added the comment: RFC8089 doesn't specify "a mechanism for translating namespaced paths ["\\?\" and "\\.\"] to or from file URIs", and the Windows shell doesn't support them. So what's the practical benefit of supporting them in nturl2path? > Windows file paths are limited to 256

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

Change by D Levine : -- type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43607] urllib's request.pathname2url not compatible with extended-length Windows file paths

New submission from D Levine : Windows file paths are limited to 256 characters, and one of Windows's prescribed methods to address this is to prepend "\\?\" before a Windows absolute path (see: https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation)