[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-03 Thread Ammar Askar
Ammar Askar added the comment: Aah thanks for pointing that out Terry, I didn't realize f-strings have different semantics for SyntaxError. Would you mind making a separate issue for that, I'll look into making the documentation for it clearer after I get a chance to investigate.

[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: Should we mention that the 4 attributes are also available as a 4-tuple that is the 2nd item of the args tuple, after the message? Doing so will help when illustrating the following. For syntax errors in f-string fields, the expanded doc is still

[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-02 Thread miss-islington
miss-islington added the comment: New changeset 06653f8d15a8a84ee0f43f739704a9a63c27de54 by Miss Islington (bot) in branch '3.8': bpo-43705: Document that SyntaxError's offsets are 1-indexed (GH-25153) https://github.com/python/cpython/commit/06653f8d15a8a84ee0f43f739704a9a63c27de54

[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-02 Thread miss-islington
miss-islington added the comment: New changeset 63c69440c7adb0de1d191a8d3d100b335d5c2f81 by Miss Islington (bot) in branch '3.9': bpo-43705: Document that SyntaxError's offsets are 1-indexed (GH-25153) https://github.com/python/cpython/commit/63c69440c7adb0de1d191a8d3d100b335d5c2f81

[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-02 Thread miss-islington
Change by miss-islington : -- pull_requests: +23903 pull_request: https://github.com/python/cpython/pull/25156 ___ Python tracker ___

[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-02 Thread miss-islington
Change by miss-islington : -- pull_requests: +23902 pull_request: https://github.com/python/cpython/pull/25155 ___ Python tracker ___

[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-02 Thread miss-islington
miss-islington added the comment: New changeset b2a91e0c9ee18b50cc86b21211c2258520a9f5d0 by Ammar Askar in branch 'master': bpo-43705: Document that SyntaxError's offsets are 1-indexed (GH-25153) https://github.com/python/cpython/commit/b2a91e0c9ee18b50cc86b21211c2258520a9f5d0 --

[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-02 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch pull_requests: +23900 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25153 ___ Python tracker ___

[issue43705] [docs] Document that SyntaxError's offsets are 1-indexed

2021-04-02 Thread Ammar Askar
New submission from Ammar Askar : As pointed out by Guido in https://bugs.python.org/issue43555, we switched to making the column offsets for SyntaxError be 1-indexed consistently in https://bugs.python.org/issue34683 The rationale is explained by Guido and expanded upon in follow up