[issue43894] IDLE editor file minor refactoring

2021-04-23 Thread E. Paine
E. Paine added the comment: I agree with your points and understand that there is good reason for the PR to be rejected. If Terry decides it's too big (I did do a lot more than what was originally in PR-22682), I am more than happy to close this issue. --

[issue43894] IDLE editor file minor refactoring

2021-04-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: This started as an extraction and revision of changes in Tal's PR, one of which appeared to be an intended behavior change, that I requested there. Paine may have expanded the scope more than I intended. Will look soon. --

[issue43894] IDLE editor file minor refactoring

2021-04-23 Thread Éric Araujo
Éric Araujo added the comment: Hello and thanks for wanting to contribute to Python! In the CPython project, stylistic changes are not made by themselves as a matter of course (accross the whole codebase or in a specific module): among reasons, these obfuscate file history, need reviewer

[issue43894] IDLE editor file minor refactoring

2021-04-20 Thread E. Paine
Change by E. Paine : -- keywords: +patch pull_requests: +24211 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25485 ___ Python tracker ___

[issue43894] IDLE editor file minor refactoring

2021-04-20 Thread E. Paine
New submission from E. Paine : Despite being large, the PR is mostly trivial changes (e.g. changing indentation). The main changes worth noting (and hence the reason for this issue) are: 1) the renaming of `ResetColorizer` to `reset_colors`, `ResetFont` to `reset_font`, `RemoveKeybindings`