[issue43921] test_ssl fails on Windows buildbots

STINNER Victor added the comment: See my comparison of read() and write() errors on Linux vs Windows: https://github.com/python/cpython/pull/26501#issuecomment-853489167 I wrote PR 26502 to fix test_wrong_cert_tls13() on Windows (currently, the test is skipped). On Linux, read() always

[issue43921] test_ssl fails on Windows buildbots

Change by STINNER Victor : -- pull_requests: +25098 pull_request: https://github.com/python/cpython/pull/26502 ___ Python tracker ___

[issue43921] test_ssl fails on Windows buildbots

Change by STINNER Victor : -- pull_requests: +25097 pull_request: https://github.com/python/cpython/pull/26501 ___ Python tracker ___

[issue43921] test_ssl fails on Windows buildbots

miss-islington added the comment: New changeset e5e93e6145090a636e67766a53b758d7ac78e3ad by Miss Islington (bot) in branch '3.10': bpo-43921: Fix test_ssl.test_pha_required_nocert() (GH-26489) https://github.com/python/cpython/commit/e5e93e6145090a636e67766a53b758d7ac78e3ad --

[issue43921] test_ssl fails on Windows buildbots

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +25090 pull_request: https://github.com/python/cpython/pull/26494 ___ Python tracker

[issue43921] test_ssl fails on Windows buildbots

STINNER Victor added the comment: New changeset 320eaa7f42b413cd5e5436ec92d4dc5ba150395f by Victor Stinner in branch 'main': bpo-43921: Fix test_ssl.test_pha_required_nocert() (GH-26489) https://github.com/python/cpython/commit/320eaa7f42b413cd5e5436ec92d4dc5ba150395f --

[issue43921] test_ssl fails on Windows buildbots

STINNER Victor added the comment: > FAIL: test_pha_required_nocert (test.test_ssl.TestPostHandshakeAuth) When this bug occurs, s.recv(1024) returns an empty byte string (b''). I wrote PR 26489 to handle this case. -- ___ Python tracker

[issue43921] test_ssl fails on Windows buildbots

Change by STINNER Victor : -- pull_requests: +25085 pull_request: https://github.com/python/cpython/pull/26489 ___ Python tracker ___

[issue43921] test_ssl fails on Windows buildbots

STINNER Victor added the comment: On the main branch, I can reproduce test_pha_required_nocert() failure: vstinner@DESKTOP-DK7VBIL C:\vstinner\python\main>python -m test test_ssl -u all -v -F -j5 -m test_pha_required_nocert test_pha_required_nocert (test.test_ssl.TestPostHandshakeAuth) ...

[issue43921] test_ssl fails on Windows buildbots

Pablo Galindo Salgado added the comment: Thanks for the explanation! > They're flakey in the sense that they're not failing reliably, when they > clearly should be :) Yeah, I do agree with you in this, but I am still not happy that they *realiably* pass in 3.9 and 3.8 in two different OS

[issue43921] test_ssl fails on Windows buildbots

Steve Dower added the comment: > But 3.9 and 3.8 are not failing on test_ssl, so do something has clearly > changed. Are the failing tests new? They're flakey in the sense that they're not failing reliably, when they clearly should be :) If something changed about how any part of the

[issue43921] test_ssl fails on Windows buildbots

Pablo Galindo Salgado added the comment: Also, this seems to be reproducible in MacOS at least: https://bugs.python.org/issue44229 -- ___ Python tracker ___

[issue43921] test_ssl fails on Windows buildbots

Pablo Galindo Salgado added the comment: > Looking at the output, I think the tests are just going to be inherently > flakey. It's not testing the specific scenario directly enough, and relying > heavily on implicit synchronization. But 3.9 and 3.8 are not failing on test_ssl, so do

[issue43921] test_ssl fails on Windows buildbots

STINNER Victor added the comment: > Looking at the output, I think the tests are just going to be inherently > flakey. It's not testing the specific scenario directly enough, and relying > heavily on implicit synchronization. My notes to debug race conditions:

[issue43921] test_ssl fails on Windows buildbots

Steve Dower added the comment: I can't reproduce these on my own (Windows) machine either. Looking at the output, I think the tests are just going to be inherently flakey. It's not testing the specific scenario directly enough, and relying heavily on implicit synchronization. We probably

[issue43921] test_ssl fails on Windows buildbots

Pablo Galindo Salgado added the comment: Also, I think the solution in: https://github.com/python/cpython/pull/25561 (skipping the test) is not acceptable for the next beta. Christian, I know that this is complicated for you yo reproduce and that this is a hard issue to debug, but this

[issue43921] test_ssl fails on Windows buildbots

Pablo Galindo Salgado added the comment: Also, this started to happen after the changes in PEP 644, and seems that reverting all changes related to the pep fixes the issue (at least I cannot reproduce it anymore after manually reverting the changes). --

[issue43921] test_ssl fails on Windows buildbots

Pablo Galindo Salgado added the comment: Ok, but bear in mind that this will block the next beta and you are the expert in this area. -- ___ Python tracker ___

[issue43921] test_ssl fails on Windows buildbots

Christian Heimes added the comment: I neither have a macOS nor a Windows machine to reproduce and debug the issue. Since I'm cannot reproduce the problem on Linux, I'm unable to debug and fix it. -- ___ Python tracker

[issue43921] test_ssl fails on Windows buildbots

Pablo Galindo Salgado added the comment: The issue is marked as referred blocker, it won't block this beta release, but it will block the next, so we should decide how to proceed by then -- ___ Python tracker

[issue43921] test_ssl fails on Windows buildbots

Pablo Galindo Salgado added the comment: Unfortunately this is still failing sporadically. Last failure 5 days ago: https://buildbot.python.org/all/#/builders/405/builds/153 -- ___ Python tracker

[issue43921] test_ssl fails on Windows buildbots

Christian Heimes added the comment: New changeset ce9a0643496ba802ea97a3da20eace3a1117ea48 by Christian Heimes in branch 'master': bpo-43921: also accept EOF in post-handshake auth test (GH-25574) https://github.com/python/cpython/commit/ce9a0643496ba802ea97a3da20eace3a1117ea48 --

[issue43921] test_ssl fails on Windows buildbots

Change by Christian Heimes : -- pull_requests: +24293 pull_request: https://github.com/python/cpython/pull/25574 ___ Python tracker ___

[issue43921] test_ssl fails on Windows buildbots

Christian Heimes added the comment: Another TLS 1.3 client cert auth test is flaky, too. https://buildbot.python.org/all/#/builders/577/builds/14/steps/4/logs/stdio == FAIL: test_pha_required_nocert

[issue43921] test_ssl fails on Windows buildbots

Christian Heimes added the comment: New changeset e047239eafefe8b19725efffe7756443495cf78b by Christian Heimes in branch 'master': bpo-43921: ignore failing test_wrong_cert_tls13 on Windows (GH-25561) https://github.com/python/cpython/commit/e047239eafefe8b19725efffe7756443495cf78b

[issue43921] test_ssl fails on Windows buildbots

Change by Pablo Galindo Salgado : -- priority: normal -> deferred blocker ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue43921] test_ssl fails on Windows buildbots

Change by Christian Heimes : -- keywords: +patch pull_requests: +24280 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25561 ___ Python tracker

[issue43921] test_ssl fails on Windows buildbots

Change by Christian Heimes : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43921] test_ssl fails on Windows buildbots

New submission from Pablo Galindo Salgado : https://buildbot.python.org/all/#/builders/405/builds/9 Extract from the logs: The Buildbot has detected a new failure on builder AMD64 Windows8.1 Non-Debug 3.x while building python/cpython. Full details are available at: