[issue43960] test_pdb fails when only some tests are run

STINNER Victor added the comment: Thanks for the fix Irit! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue43960] test_pdb fails when only some tests are run

STINNER Victor added the comment: New changeset b52cc7c5f1a6c5b48d51cd718719a766c37d6e38 by Miss Islington (bot) in branch '3.8': bpo-43960: test_pdb resets breakpoints to make tests deterministic (GH-25691) (GH-25692)

[issue43960] test_pdb fails when only some tests are run

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8, Python 3.9 ___ Python tracker ___

[issue43960] test_pdb fails when only some tests are run

Change by miss-islington : -- pull_requests: +24382 pull_request: https://github.com/python/cpython/pull/25692 ___ Python tracker ___

[issue43960] test_pdb fails when only some tests are run

STINNER Victor added the comment: New changeset 2dc6b1789ec86dc80ea290fe33edd61140e47f6f by Irit Katriel in branch '3.9': bpo-43960: test_pdb resets breakpoints to make tests deterministic (GH-25691) https://github.com/python/cpython/commit/2dc6b1789ec86dc80ea290fe33edd61140e47f6f

[issue43960] test_pdb fails when only some tests are run

Change by Irit Katriel : -- pull_requests: +24381 pull_request: https://github.com/python/cpython/pull/25691 ___ Python tracker ___

[issue43960] test_pdb fails when only some tests are run

STINNER Victor added the comment: > We didn't backport PR21989 because it was changing the way breakpoints hare > maintained, so reset_Breakpoint is not there before 3.10. I can add that to > the test file manually. Ah yes, it sounds reasonable to me to add reset_Breakpoint() to test_pdb

[issue43960] test_pdb fails when only some tests are run

Irit Katriel added the comment: We didn't backport PR21989 because it was changing the way breakpoints hare maintained, so reset_Breakpoint is not there before 3.10. I can add that to the test file manually. -- ___ Python tracker

[issue43960] test_pdb fails when only some tests are run

STINNER Victor added the comment: Irit: the automated backported failed, test_pdb fails with: NameError: name 'reset_Breakpoint' is not defined Do you want to try to backport manually the change to Python 3.9 (and then I can automate the backport to 3.8). test_pdb on Python 3.8 and 3.9

[issue43960] test_pdb fails when only some tests are run

Change by miss-islington : -- pull_requests: +24372 pull_request: https://github.com/python/cpython/pull/25682 ___ Python tracker ___

[issue43960] test_pdb fails when only some tests are run

STINNER Victor added the comment: New changeset 21b02b5f4018474620676be04310f7d230a464ea by Irit Katriel in branch 'master': bpo-43960: test_pdb resets breakpoints (GH-25673) https://github.com/python/cpython/commit/21b02b5f4018474620676be04310f7d230a464ea --

[issue43960] test_pdb fails when only some tests are run

Change by miss-islington : -- nosy: +miss-islington nosy_count: 2.0 -> 3.0 pull_requests: +24371 pull_request: https://github.com/python/cpython/pull/25681 ___ Python tracker

[issue43960] test_pdb fails when only some tests are run

Irit Katriel added the comment: I scanned the file and I think this was the only test where this was missing. test_pdb_continue_in_bottomframe doesn't have a reset, but it doesn't expect a specific breakpoint number, it does: Breakpoint ... at

[issue43960] test_pdb fails when only some tests are run

Change by Irit Katriel : -- keywords: +patch pull_requests: +24364 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25673 ___ Python tracker ___

[issue43960] test_pdb fails when only some tests are run

Irit Katriel added the comment: I have a fix, I'll make a PR in a bit. The issue here is the breakpoint number: Breakpoint 1 at https://github.com/python/cpython/pull/21989/files So I will make this test use it. -- nosy: +iritkatriel ___ Python

[issue43960] test_pdb fails when only some tests are run

New submission from STINNER Victor : test_pdb fails with the following commands. I tested on Linux, same/similar failure on Windows. See also bpo-41914: "test_pdb fails". $ cat bisect test.test_pdb.PdbTestCase.test_run_module test.test_pdb.test_next_until_return_at_return_event