[issue43981] test_idle is leaking references

Tal Einat added the comment: Pablo, many thanks for catching this, analyzing it and finding a fix! Sorry for missing this cleanup in the first place, and moreso for not having being able to look into this when you brought it up. -- ___ Python

[issue43981] test_idle is leaking references

Terry J. Reedy added the comment: I was just about to try adding that exact cleanup close after finishing reading emails ;-). Sorry I didn't think of it last night. Glad it worked. The alternative would have been to skip the test case. -- ___

[issue43981] test_idle is leaking references

Pablo Galindo Salgado added the comment: Refleaks fixed by 6689e45dfee75d756c540ff0946ebf0ae8847f43 -- ___ Python tracker ___ ___

[issue43981] test_idle is leaking references

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43981] test_idle is leaking references

Pablo Galindo Salgado added the comment: New changeset 6689e45dfee75d756c540ff0946ebf0ae8847f43 by Pablo Galindo in branch 'master': bpo-43981: Fix reference leaks in test_squeezer (GH-25758) https://github.com/python/cpython/commit/6689e45dfee75d756c540ff0946ebf0ae8847f43 --

[issue43981] test_idle is leaking references

Change by Pablo Galindo Salgado : -- pull_requests: +24448 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25758 ___ Python tracker ___

[issue43981] test_idle is leaking references

Pablo Galindo Salgado added the comment: Unfortunately given how close are we to the beta release and per our buildbot policy (https://discuss.python.org/t/policy-to-revert-commits-on-buildbot-failure/404) I may need to revert commit 15d3861856 to avoid masking other issues. --

[issue43981] test_idle is leaking references

Pablo Galindo Salgado added the comment: I checked and reverting commit 15d3861856 fixes the leaks. -- ___ Python tracker ___ ___

[issue43981] test_idle is leaking references

Pablo Galindo Salgado added the comment: Taking into account the last time the builder built successully it must have happened in some of these commits: b38b2fa021 Document importlib.metadata.PackagePath.locate method (GH-25669) 4a85718212 bpo-43970: Optimize Path.cwd() in pathlib by not

[issue43981] test_idle is leaking references

Pablo Galindo Salgado added the comment: I will try to investigate today or tomorrow but notice that is very possible that the leak is somewhere else in the interpreter and is just showing in the IDLE tests. -- ___ Python tracker

[issue43981] test_idle is leaking references

Terry J. Reedy added the comment: test_squeezer.ExpandingButtonTest accounts for most of the leak. python -m test -R3:3 -v -ugui -m *zer.Expand* test_idle test_idle leaked [576, 576, 576] references, sum=1728 test_idle leaked [282, 282, 282] memory blocks, sum=846 All 6 methods failed. I

[issue43981] test_idle is leaking references

Terry J. Reedy added the comment: New changeset a62e424de0c394cda178a8d934d06f0559b5e28d by Terry Jan Reedy in branch 'master': bpo-43981: Fix error in idle-test leak test (GH-25739) https://github.com/python/cpython/commit/a62e424de0c394cda178a8d934d06f0559b5e28d --

[issue43981] test_idle is leaking references

Change by Terry J. Reedy : -- keywords: +patch pull_requests: +24430 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25739 ___ Python tracker ___

[issue43981] test_idle is leaking references

Terry J. Reedy added the comment: The only recently added tests are the 11 in test_sidebar.ShellSidebarTest. Leak testing just these with python -m test -R3:3 -ugui -m *Sidebar* test_idle does not fail. Leak test all of test_idle with >python -m test -R3:3 -v -ugui test_idle ends after

[issue43981] test_idle is leaking references

Pablo Galindo Salgado added the comment: Marking this as a release blocker -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue43981] test_idle is leaking references

New submission from Pablo Galindo Salgado : See for example: https://buildbot.python.org/all/#/builders/511/builds/10/steps/4/logs/stdio test_idle leaked [684, 684, 684] references, sum=2052 test_idle leaked [282, 282, 282] memory blocks, sum=846 -- assignee: terry.reedy components: