[issue43988] Add test.support.assert_dissallow_instantiation

STINNER Victor added the comment: > I believe we can close this now, Victor. Please reopen if you disagree :) I validated that all tests named "test(...)disallow(...)inst(...)" are now using support.check_disallow_instantiation(). Lib/test/test_tcl.py might use it in:

[issue43988] Add test.support.assert_dissallow_instantiation

Erlend E. Aasland added the comment: I believe we can close this now, Victor. Please reopen if you disagree :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue43988] Add test.support.assert_dissallow_instantiation

STINNER Victor added the comment: New changeset 8cec740820fc875117bfa7b6bdb10202ebeb8fd5 by Erlend Egeberg Aasland in branch 'main': bpo-43988: Document test.support.check_disallow_instantiation() (GH-26394) https://github.com/python/cpython/commit/8cec740820fc875117bfa7b6bdb10202ebeb8fd5

[issue43988] Add test.support.assert_dissallow_instantiation

STINNER Victor added the comment: New changeset fbff5387c3e1f3904420fa5a27738c6c5881305b by Erlend Egeberg Aasland in branch 'main': bpo-43988: Use check disallow instantiation helper (GH-26392) https://github.com/python/cpython/commit/fbff5387c3e1f3904420fa5a27738c6c5881305b --

[issue43988] Add test.support.assert_dissallow_instantiation

Change by Erlend E. Aasland : -- pull_requests: +24987 pull_request: https://github.com/python/cpython/pull/26394 ___ Python tracker ___

[issue43988] Add test.support.assert_dissallow_instantiation

Change by Erlend E. Aasland : -- pull_requests: +24985 pull_request: https://github.com/python/cpython/pull/26392 ___ Python tracker ___

[issue43988] Add test.support.assert_dissallow_instantiation

STINNER Victor added the comment: New changeset 4f725261c6cf23d259e8fdc205e12b76ef4d2d31 by Erlend Egeberg Aasland in branch 'main': bpo-43988: Add test.support.check_disallow_instantiation() (GH-25757) https://github.com/python/cpython/commit/4f725261c6cf23d259e8fdc205e12b76ef4d2d31

[issue43988] Add test.support.assert_dissallow_instantiation

STINNER Victor added the comment: You can keep PR 25757 to add the helper function, and then write a second PR to use it in all tests. -- ___ Python tracker ___

[issue43988] Add test.support.assert_dissallow_instantiation

Erlend Egeberg Aasland added the comment: I'll fix your typo ;) I'll include the rest of the test in the PR. I just pushed it out quickly to get a review of the solution. -- ___ Python tracker

[issue43988] Add test.support.assert_dissallow_instantiation

STINNER Victor added the comment: You can take this issue as an opportunity to fix my typo :-) Lib/test/test_hashlib.py: "test_disallow_instanciation" => "test_disallow_instantiation". https://github.com/python/cpython/commit/665c7746fca180266b121183c2d5136c547006e0#commitcomment-50235589

[issue43988] Add test.support.assert_dissallow_instantiation

Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +24447 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25757 ___ Python tracker

[issue43988] Add test.support.assert_dissallow_instantiation

Change by Erlend Egeberg Aasland : -- type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43988] Add test.support.assert_dissallow_instantiation

New submission from Erlend Egeberg Aasland : See https://github.com/python/cpython/pull/25748#discussion_r623849521: "What do you think of adding support.assert_disallow_instanciation(type, *args) function which would check for TypeError but also check the error message? TypeError is quite