[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

Łukasz Langa added the comment: Thanks, Hai Shi! ✨  ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

Łukasz Langa added the comment: New changeset 52d9d3b75441ae6038fadead89eac5eecdd34501 by Łukasz Langa in branch '3.9': [3.9] bpo-44050: Extension modules can share state when they don't support sub-interpreters. (GH-27794) (GH-28741)

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

Łukasz Langa added the comment: New changeset d0d29655ffc43d426ad68542d8de8304f7f1346a by Miss Islington (bot) in branch '3.10': bpo-44050: Extension modules can share state when they don't support sub-interpreters. (GH-27794) (GH-28738)

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

Change by Łukasz Langa : -- pull_requests: +27088 pull_request: https://github.com/python/cpython/pull/28741 ___ Python tracker ___

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

STINNER Victor added the comment: Thanks for the fix. I don't understand well this code :-( -- ___ Python tracker ___ ___

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

miss-islington added the comment: New changeset b9bb74871b27d9226df2dd3fce9d42bda8b43c2b by Hai Shi in branch 'main': bpo-44050: Extension modules can share state when they don't support sub-interpreters. (GH-27794)

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

Change by miss-islington : -- pull_requests: +27086 pull_request: https://github.com/python/cpython/pull/28738 ___ Python tracker ___

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

hai shi added the comment: > (Note that the "def->m_size == -1" means that the module does not support > sub-interpreters, because it has global state. Make Sense. It's more better and exact than my suggestion :) -- ___ Python tracker

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

hai shi added the comment: > Maybe the old behavior was better: if an extension uses the old API, share > its state between all interpreters. +1. I create PR-27794, which use `def->m_slots` to identify the extension module created from `PyModule_Create()` or not. cc @petr --

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

Petr Viktorin added the comment: > Maybe the old behavior was better: if an extension uses the old API, share > its state between all interpreters. Yes, I think the old behavior was better: if an extension uses the old API, share its state between all interpreters. This is obviously bad,

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

Change by hai shi : -- keywords: +patch pull_requests: +26263 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27794 ___ Python tracker ___

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

Trygve Aaberge added the comment: @jack__d: If you're just getting "no data" once and nothing else, the test isn't working correctly. You should get "no data" twice when it works correctly and the issue is fixed, or "unknown error" and some other info if the issue is present. I'm not sure

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

Jack DeVries added the comment: I just took a look at this, and I'm getting an output of "no data" (just one time) on 3.9.6. Has this been fixed? -- nosy: +jack__d ___ Python tracker

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

Trygve Aaberge added the comment: > The _PyImport_FixupExtensionObject() change impacts extensions using the > legacy API and so should not be used in subinterpreters. I'm not using that directly in my code, but I guess it's used indirectly? If it shouldn't be used, what's the alternative

[issue44050] [subinterpreters] _PyImport_FixupExtensionObject() regression in Python 3.9

STINNER Victor added the comment: > The commit that fixes the issue in 3.10 is > https://github.com/python/cpython/commit/7f1305ef9ea7234e1a5aacbea17490232e9b7dc2 Right, the _ssl module was ported to multiphase initialization (PEP 489) in bpo-42333 (fixed in Python 3.10.0a3). > This is a