[issue44291] Unify logging.handlers.SysLogHandler behavior with SocketHandlers

Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue44291] Unify logging.handlers.SysLogHandler behavior with SocketHandlers

Vinay Sajip added the comment: New changeset 3d315c311676888201f4a3576e4ee3698684a3a2 by Kirill Pinchuk in branch 'main': bpo-44291: Fix reconnection in logging.handlers.SysLogHandler (GH-26490) https://github.com/python/cpython/commit/3d315c311676888201f4a3576e4ee3698684a3a2 --

[issue44291] Unify logging.handlers.SysLogHandler behavior with SocketHandlers

Vinay Sajip added the comment: > Oh, sorry bad wording. OK, I see. Will take a look soon. > it looks like we can refactor SysLogHandler to inherit from SocketHandler. > Not sure if it should be done in this PR Better a separate PR for that, I feel. Removing the older Pythons from the

[issue44291] Unify logging.handlers.SysLogHandler behavior with SocketHandlers

Kirill Pinchuk added the comment: Oh, sorry bad wording. The current implementation has reconnection logic only for UNIX sockets The patch adds reconnection logic for UDP/TCP sockets as well. I've done it with minimal changes to the existing code to accomplish that. And probably it can be

[issue44291] Unify logging.handlers.SysLogHandler behavior with SocketHandlers

Vinay Sajip added the comment: > right now it has reconnection logic for unixsocket but not for tcp/udp Should it not have UDP/TCP supported as well as domain sockets, before being reviewed? -- nosy: +vinay.sajip ___ Python tracker

[issue44291] Unify logging.handlers.SysLogHandler behavior with SocketHandlers

Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 1.0 -> 2.0 pull_requests: +25086 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26490 ___ Python tracker

[issue44291] Unify logging.handlers.SysLogHandler behavior with SocketHandlers

Kirill Pinchuk added the comment: UPD: right now it has reconnection logic for unixsocket but not for tcp/udp -- ___ Python tracker ___

[issue44291] Unify logging.handlers.SysLogHandler behavior with SocketHandlers

New submission from Kirill Pinchuk : Probably we should make the behavior of SysLogHandler consistent with other Socket handlers. Right now SocketHandler and DatagramHandler implement such behavior: 1) on `close` set `self.socket = None` 2) when trying to send - make socket when it is None