[issue44600] match/case statements trace incorrectly in 3.10.0b4

Łukasz Langa added the comment: New changeset 5502ee052fb4257ad7438dd1130c80e1a9c4bc7f by Miss Islington (bot) in branch '3.10': bpo-44600: Refactor new tracing tests (GH-27396) (GH-27404) https://github.com/python/cpython/commit/5502ee052fb4257ad7438dd1130c80e1a9c4bc7f -- nosy: +luk

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Change by miss-islington : -- pull_requests: +25937 pull_request: https://github.com/python/cpython/pull/27404 ___ Python tracker ___ __

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Brandt Bucher added the comment: New changeset 38ddc8beb38d9a685de296a58b0741850e4853e5 by Brandt Bucher in branch 'main': bpo-44600: Refactor new tracing tests (GH-27396) https://github.com/python/cpython/commit/38ddc8beb38d9a685de296a58b0741850e4853e5 -- _

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Change by miss-islington : -- pull_requests: +25930 pull_request: https://github.com/python/cpython/pull/27397 ___ Python tracker ___ __

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Change by Brandt Bucher : -- pull_requests: +25929 pull_request: https://github.com/python/cpython/pull/27396 ___ Python tracker ___ ___

[issue44600] match/case statements trace incorrectly in 3.10.0b4

miss-islington added the comment: New changeset 01601aa7360ae51e74a64dbe957288096bb364fd by Miss Islington (bot) in branch '3.10': [3.10] bpo-44600: Fix line numbers for pattern matching cleanup code (GH-27346) (GH-27356) https://github.com/python/cpython/commit/01601aa7360ae51e74a64dbe95728

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Change by Brandt Bucher : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +25897 pull_request: https://github.com/python/cpython/pull/27356 ___ Python tracker _

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Brandt Bucher added the comment: New changeset 4214f470f0cb9b6fef9a90758756fbc00ba95b5a by Charles Burkland in branch 'main': bpo-44600: Fix line numbers for pattern matching cleanup code (GH-27346) https://github.com/python/cpython/commit/4214f470f0cb9b6fef9a90758756fbc00ba95b5a --

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Change by Charles Burkland : -- keywords: +patch nosy: +chaburkland nosy_count: 6.0 -> 7.0 pull_requests: +25887 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27346 ___ Python tracker

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Brandt Bucher added the comment: Yup, I plan on having it in this weekend. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Change by Pablo Galindo Salgado : -- priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Pablo Galindo Salgado added the comment: The release candidate is soon, so I would recommend to land a fix as soon as possible so it can be tested for some time before is released, if that is possible. -- nosy: +pablogsal ___ Python tracker

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Brandt Bucher added the comment: Two other things we realized while working on this: - The first occurrence of line 15 in the example output should be marked as incorrectly traced. - We should emit a NOP to show coverage of "case _" (that fix will be part of the same PR). -- _

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Brandt Bucher added the comment: Yeah, this is actively being worked on. Thanks for asking. If anything changes, I’ll let you know and you can pick it up then! -- ___ Python tracker _

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Jack DeVries added the comment: @brandtbucher, is anyone working on this yet? I'd like to take a crack at it this week if it's still available! -- nosy: +jack__d ___ Python tracker _

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Brandt Bucher added the comment: Thanks, that test framework looks good for this. My initial hunch (just from looking at this) is that this has to do with how we handle cleanup after failed matches. Our "fail pop" blocks probably have whatever the last line number compiled was (which I think

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Ammar Askar added the comment: Brandt, maybe this regression test from a previous tracing bug might be useful for the test writing: https://github.com/python/cpython/pull/22026/files#diff-8b73bfc55514d8add8904c5f4d1d24b7b644ebfccba8d846085303577aa94dd6 -- nosy: +ammar2 _

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Brandt Bucher added the comment: Thanks, I'll take a closer look at this soon (most likely this coming week). Out of curiosity, do we have a standard way of writing regression tests for correct line numbers like this? Of the top of my head, it seems like we could either statically compare th

[issue44600] match/case statements trace incorrectly in 3.10.0b4

Change by Mark Shannon : -- nosy: +brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue44600] match/case statements trace incorrectly in 3.10.0b4

New submission from Ned Batchelder : Some simple match/case statements show incorrect tracing. Below is the code to run, as well as the output. Output lines with initial stars are incorrect: they incorrectly indicate that case bodies are executing when they are not. Sorry for the bulk here,