Antoine Pitrou pit...@free.fr added the comment:
The starttls patch has been committed in r86431. Thank you very much for
writing the initial patch.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python
Antoine Pitrou pit...@free.fr added the comment:
I've committed some of the remote tests in r86380, which also helped me fix a
bug in login() in 3.x.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4471
Antoine Pitrou pit...@free.fr added the comment:
The shutdown change was committed in r86383.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4471
___
Antoine Pitrou pit...@free.fr added the comment:
Here is an updated STARTTLS patch for py3k.
--
stage: - patch review
type: - feature request
versions: +Python 3.2 -Python 2.6
Added file: http://bugs.python.org/file19562/imaptls.patch
___
Python
Bill Janssen bill.jans...@gmail.com added the comment:
I brought this up on pydotorg, and Barry suggests that someone put
together a Twisted environment which could be downloaded and run locally
on the test machine. It would provide IMAP and POP servers, perhaps
NNTP and others as well. Now,
Bill Janssen bill.jans...@gmail.com added the comment:
Why can't we use python.org for tests? Do we need IMAP/POP servers
running? Let's send some mail to pydotorg to get that set up.
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: -haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4471
___
___
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
As the tests are new, I hope sending the real file is the right way to
proceed.
Added file: http://bugs.python.org/file12963/test_imapnet.py
___
Python tracker rep...@bugs.python.org
Bill Janssen bill.jans...@gmail.com added the comment:
Lorenzo, do we have test cases for this? I think you should try to add
some test cases. We may need to set up some test mail servers on
python.org to accommodate such tests.
--
nosy: +janssen
Gregory P. Smith g...@krypto.org added the comment:
For network tests like this where it is useful to test against external
servers, could we just pick few known external servers that are unlikely
to every go away?
imap.gmail.com:993 for instance? (i don't know enough about imap to
know if
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
I just found out that the gmail servers don't support connections on
the standard pop3/imapv4 ports, but only on the SSL wrapped ones.
I'm unsure if cmu.edu anonymous imap server admin's would be happy with
their server
Lorenzo M. Catucci lore...@sancho.ccd.uniroma2.it added the comment:
Thanks for following-up, Bill.
While I fully understand the need for unit-testing, I don't have the
guts to start writing a dummy imap server from scratch.
I tested my changes on a couple of servers I manage, one running
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
As requested, I've split the patch into three parts: the first one does
just refactor IMAP4_SSL, the second is really a one liner for shutting
down the socket before closing it, and the thirs does introduce the
starttls method in IMAP4.
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12194/imaplib_02_shutdown.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4471
___
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Added file: http://bugs.python.org/file12195/imaplib_03_starttls.diff
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4471
___
Changes by Lorenzo M. Catucci [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file12169/imaplib.py.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4471
___
Changes by Giampaolo Rodola' [EMAIL PROTECTED]:
--
nosy: +giampaolo.rodola
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4471
___
___
Python-bugs-list
STINNER Victor [EMAIL PROTECTED] added the comment:
Same comments than issue #4473:
- you might split your patch into smaller patches
- Do you really need to keep a reference to the raw socket?
- I don't understand what is sock.shutdown(SHUT_RDWR). When is it
needed? Does it change the
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
As in #4473: if needed, I'll redo the patch into a small
series. I've cut and pasted the following.
As for the shutdown before close, it's needed to let the server know
we are leaving, instead of waiting until socket timeout. This is the
New submission from Lorenzo M. Catucci [EMAIL PROTECTED]:
In the enclosed patch, there are three changes:
1. Support starttls on IMAP4 connections
2. Rework of the IMAP_SSL, to replace home-grown file-like
methods with proper ones from ssl module's makefile();
3. Properly shutdown sockets at
Lorenzo M. Catucci [EMAIL PROTECTED] added the comment:
the needed changes to library documentation if the patch is accepted
Added file: http://bugs.python.org/file12171/imaplib.rst.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue4471
21 matches
Mail list logo
