[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Łukasz Langa added the comment: New changeset 9ef1843892500e209afe5d916db26ecdbccd5e62 by Łukasz Langa in branch '3.9': bpo-44756: Remove misleading NEWS entries of a change that was reverted before release (GH-28075)

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Łukasz Langa added the comment: New changeset 5246dbc2a12bf8e64e18efee2fdce02a350bbf09 by Łukasz Langa in branch 'main': bpo-44756: Remove misleading NEWS entries of a change that was reverted before release (GH-28075)

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Change by Łukasz Langa : -- pull_requests: +26519 pull_request: https://github.com/python/cpython/pull/28075 ___ Python tracker ___

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Łukasz Langa added the comment: Revert done. Re-closing! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

miss-islington added the comment: New changeset 1e9c9ca570ffe92dc6a60825c2f9c91865129b8f by Miss Islington (bot) in branch '3.10': bpo-44756: [docs] revert automated virtual environment creation on `make html` (GH-27635)

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Łukasz Langa added the comment: New changeset 91f6d386691c060dfaa870d74b370e9c10eb8cd8 by Miss Islington (bot) in branch '3.9': bpo-44756: [docs] revert automated virtual environment creation on `make html` (GH-27635) (GH-27636)

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Change by miss-islington : -- pull_requests: +26131 pull_request: https://github.com/python/cpython/pull/27637 ___ Python tracker ___

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Change by miss-islington : -- pull_requests: +26130 pull_request: https://github.com/python/cpython/pull/27636 ___ Python tracker ___

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Łukasz Langa added the comment: New changeset 55fa87b1ef46bbb9db7612b2dc2dd7fb039d9bc3 by Łukasz Langa in branch 'main': bpo-44756: [docs] revert automated virtual environment creation on `make html` (GH-27635) https://github.com/python/cpython/commit/55fa87b1ef46bbb9db7612b2dc2dd7fb039d9bc3

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Change by Łukasz Langa : -- pull_requests: +26129 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/27635 ___ Python tracker ___

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Change by Ned Deily : -- versions: +Python 3.10, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Ned Deily added the comment: There was a previous attempt at adding a dependency on venv that ended up being reverted (Issue30487 and 122fc136b34e11906466851e77bb6959946467ee0). Over the years we have had a number of iterations of tweaking Doc/Makefile to balance ease of use (by providing

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Pablo Galindo Salgado added the comment: Note this issue has impacted negatively the release process of 3.10.0rc1: https://bugs.python.org/issue44823 -- ___ Python tracker

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Petr Viktorin added the comment: I've sent a mail to python-dev: https://mail.python.org/archives/list/python-...@python.org/thread/MGPNI7OSA7UXNOTVDVW2I2GUMXV25FRS/ -- ___ Python tracker

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Petr Viktorin added the comment: The issue this (or lack of communication about it) caused in rc1 is tracked in https://bugs.python.org/issue44823 > @petr.viktorin a whatsnew entry was added, what more notice could have been > provided? Ideally, the python-dev mailing list (or Discourse).

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Miro Hrončok added the comment: The 3.10.0rc1 source tarballs contain the Docs/venv directory populated with pablogsal's venv: issue44824 -- nosy: +hroncok ___ Python tracker

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Jack DeVries added the comment: Actually, I tested out that idea (https://github.com/python/cpython/compare/main...jdevries3133:bpo-44756-doc-make), and I don't think its as nice of a solution. I think it is valuable for new contributors to be able to type "make html" and have it work. Look

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Jack DeVries added the comment: @petr.viktorin a whatsnew entry was added, what more notice could have been provided? I have an idea for an alternative that might be better. What if ``make clean`` deletes and restores the venv only if it already existed in the first place? --

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Petr Viktorin added the comment: I'm one of those who disagree with "make html" suddenly downloading code from the internet and running it, but I guess I'm in a minority. I'll switch to using `sphinx-build` directly. Still, I'd have appreciated a heads-up notice. -- nosy:

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Łukasz Langa added the comment: New changeset fd2c2465d49a8bcb32eeda82d694eed48e57ba79 by Miss Islington (bot) in branch '3.9': bpo-44756: in ./Doc, `make build` depends on `make html` (GH-27403) (GH-27411) https://github.com/python/cpython/commit/fd2c2465d49a8bcb32eeda82d694eed48e57ba79

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Łukasz Langa added the comment: Thanks, Jack! ✨  ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Łukasz Langa added the comment: New changeset f113195ac85d58bdde348b5bb74eb97e6485e408 by Miss Islington (bot) in branch '3.10': bpo-44756: in ./Doc, `make build` depends on `make html` (GH-27403) (GH-27410) https://github.com/python/cpython/commit/f113195ac85d58bdde348b5bb74eb97e6485e408

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +25943 pull_request: https://github.com/python/cpython/pull/27410 ___ Python tracker

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Łukasz Langa added the comment: New changeset d22c876d5ac5fa464337d2e82654b8d87a83cb1b by Jack DeVries in branch 'main': bpo-44756: in ./Doc, `make build` depends on `make html` (#27403) https://github.com/python/cpython/commit/d22c876d5ac5fa464337d2e82654b8d87a83cb1b -- nosy:

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Change by miss-islington : -- pull_requests: +25944 pull_request: https://github.com/python/cpython/pull/27411 ___ Python tracker ___

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

Change by Jack DeVries : -- keywords: +patch pull_requests: +25936 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27403 ___ Python tracker ___

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

New submission from Jack DeVries : In Doc/Makefile, all of the build rules should be dependent on the existence of a virtual environment. I could see this being controversial, because folks who have these tools installed elsewhere might prefer not to have a venv made for them, but my personal