[issue44771] Adopt changes from importlib_resources 5.2

Jason R. Coombs added the comment: Reported concern can be addressed in the new issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue44771] Adopt changes from importlib_resources 5.2

STINNER Victor added the comment: test_importlib.test_read_bytes() is failing for 1 month on AMD64 Windows8.1 Non-Debug 3.x. Please see bpo-45078, the regression may be caused by the commit aaa83cdfab6817446285e631232f64b394ac6791. -- nosy: +vstinner

[issue44771] Adopt changes from importlib_resources 5.2

Jason R. Coombs added the comment: New changeset e63e6311aa258a5f3f49a7aed9fdde445fd384d6 by Jason R. Coombs in branch 'main': bpo-44771: Sync with importlib_resources 5.2.2, fixing refleak. (#27497) https://github.com/python/cpython/commit/e63e6311aa258a5f3f49a7aed9fdde445fd384d6 -

[issue44771] Adopt changes from importlib_resources 5.2

Change by Jason R. Coombs : -- pull_requests: +26015 pull_request: https://github.com/python/cpython/pull/27497 ___ Python tracker ___ _

[issue44771] Adopt changes from importlib_resources 5.2

Change by Filipe Laíns : -- pull_requests: +26000 pull_request: https://github.com/python/cpython/pull/27484 ___ Python tracker ___ _

[issue44771] Adopt changes from importlib_resources 5.2

Change by Pablo Galindo Salgado : -- pull_requests: +25999 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/27483 ___ Python tracker ___ ___

[issue44771] Adopt changes from importlib_resources 5.2

Pablo Galindo Salgado added the comment: Seems that PR 27436 has broken several buildbots. For instance: https://buildbot.python.org/all/#/builders/350/builds/474 Following our buildbot policy, we will sadly need to revert in 24 if is not fixed. -- nosy: +pablogsal resolution: fixed

[issue44771] Adopt changes from importlib_resources 5.2

Change by Jason R. Coombs : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue44771] Adopt changes from importlib_resources 5.2

Jason R. Coombs added the comment: New changeset aaa83cdfab6817446285e631232f64b394ac6791 by Jason R. Coombs in branch 'main': bpo-44771: Apply changes from importlib_resources 5.2.1 (GH-27436) https://github.com/python/cpython/commit/aaa83cdfab6817446285e631232f64b394ac6791 -- ___

[issue44771] Adopt changes from importlib_resources 5.2

Jason R. Coombs added the comment: In [this comment](https://github.com/python/importlib_resources/pull/221#discussion_r679124389), I did more analysis and assuaged my own concerns about the implementation. Everything seems to be working as intended, thanks to the strong work by FFY00.

[issue44771] Adopt changes from importlib_resources 5.2

Jason R. Coombs added the comment: On further consideration, the concern I had may not be manifest in the implementation. It may be the _adapters.wrap_spec provides all the compatibility that's needed. I'll see if I can concoct an idiomatic case, but I may find that there's no concern at all

[issue44771] Adopt changes from importlib_resources 5.2

Jason R. Coombs added the comment: I've put together a patch based on python/importlib_resources@3b24bd6307, and interestingly, the tests pass... which is a little concerning because in https://github.com/python/importlib_resources/pull/221#discussion_r659214483, I describe a compatibility c

[issue44771] Adopt changes from importlib_resources 5.2

Change by Jason R. Coombs : -- nosy: +FFY00 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue44771] Adopt changes from importlib_resources 5.2

Change by Jason R. Coombs : -- keywords: +patch pull_requests: +25965 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27436 ___ Python tracker ___

[issue44771] Adopt changes from importlib_resources 5.2

New submission from Jason R. Coombs : Importlib_resources 5.1 and 5.2 introduced the following changes (more details at https://importlib-resources.readthedocs.io/en/latest/history.html#v5-2-1): - Added ``simple`` module implementing adapters from a low-level resources reader interface to a `