[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Chris Satterlee added the comment: FYI, it appears that 8.6.11 works ok with MacOS 12.1 (released on 13-Dec-2021). 8.6.12 also works with MacOS 12.1. I have not tested either extensively, however. -- nosy: +csatt ___ Python tracker

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: Thanks everyone, especially Marc! python.org macOS installers for 3.9.8, 3.10.0, and 3.11.0a2 with patched versions of Tk to avoid the filedialog problems on macOS 12 Monterey are now released and available for download. We can now close this issue and move on

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: Well, not exactly ... culler@abner ~ % export SYSTEM_VERSION_COMPAT=1 culler@abner ~ % sw_vers ProductName:Mac OS X ProductVersion: 10.16 BuildVersion: 20G224 culler@abner ~ % export SYSTEM_VERSION_COMPAT=0 culler@abner ~ % sw_vers

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ronald Oussoren added the comment: > Where do you think that "feature" is documented? I'd have to check, but I didn't learn this from Twitter, although it wouldn't surprise me if I learned this from a WWDC talk. The beta for Big Sur never identified itself as 10.16 other than through this

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Łukasz Langa added the comment: New changeset 10b0c671580a2f8dd013b6345c1dc9789d5bd95c by Ned Deily in branch '3.8': bpo-44828: Avoid leaving a zombie Save panel (GH-29372) https://github.com/python/cpython/commit/10b0c671580a2f8dd013b6345c1dc9789d5bd95c --

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Zack McCauley added the comment: If you use the older methods to detect OSVersion, Monterey will also identify as 10.16. iirc there’s an environment variable to enable or disable that. On Thu, Nov 4, 2021 at 7:54 AM Marc Culler wrote: > > Marc Culler added the comment: > > According to

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: According to wikipedia, it was only the Big Sur beta that identified itself as 10.16. (And I observed this with the beta). But the release and, I think, the later Big Sur betas stopped doing that. But I did eventually find a page showing a tweet that

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: Where do you think that "feature" is documented? -- ___ Python tracker ___ ___ Python-bugs-list

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ronald Oussoren added the comment: > Heads up! A strange Apple quirk has been identified which could affect the > file dialog behavior if the Tk library is compiled on macOS 10.XX and used on > macOS 11 or 12. (I am not sure if this applies here.) I'm pretty sure that's a documented

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Zack McCauley added the comment: Awesome, thanks for the clear update reason. Makes more sense now. I was able to get our software to patch around. An API to get the installer urls would be super helpful. Thanks Ned! On Wed, Nov 3, 2021 at 4:19 PM Ned Deily wrote: > > Ned Deily added the

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: After I posted the previous reply, I saw that there have been other users affected by this, so I have now also made the updated installer available under the old URL. -- ___ Python tracker

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: > Could this be bumped to a version update to like 3.10.1 or just replace the > old package with this updated one? I'm sorry that this caused problems for you. We rarely update the artifacts for a release but, in this case, 3.10.1 was not scheduled for release

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Zack McCauley added the comment: Could this be bumped to a version update to like 3.10.1 or just replace the old package with this updated one? The package name and format now break automations that relied on matching version names in the url. This pattern has worked since 2.7 releases. For

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: OK, thanks to Marc's quick response, it looks like we have conquered the elusive zombie dialog window. So let's try again. Note that the download file name has changed to avoid any confusion: As of 2021-11-03, the macOS installer file on python.org for the

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: New changeset d53d9e7f4f1656a13b030b17baca743455e511fd by Ned Deily in branch '3.9': bpo-44828: Avoid leaving a zombie Save panel. (GH-29371) https://github.com/python/cpython/commit/d53d9e7f4f1656a13b030b17baca743455e511fd --

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by Fahim Faisal : -- nosy: -i3p9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: New changeset 6681a77c52df41636feb213d63ba27a759c7e5f4 by Ned Deily in branch '3.10': bpo-44828: Avoid leaving a zombie Save panel. (GH-29369) https://github.com/python/cpython/commit/6681a77c52df41636feb213d63ba27a759c7e5f4 --

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: A (hypothetical) explanation: I think that each NSWindow maintains a queue of attached sheets. Failing to call the [parent endSheet] method left the file dialogue NSPanel in the queue, although it had been ordered offscreen and so was not visible. Opening the

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: New changeset 4a8b4051734fd2ce46e15e6369811132ac3a5697 by Ned Deily in branch 'main': bpo-44828: macOS installer: avoid leaving a zombie Save panel in Tk 8.6.12rc1 (GH-29367) https://github.com/python/cpython/commit/4a8b4051734fd2ce46e15e6369811132ac3a5697

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by Ned Deily : -- pull_requests: +27630 pull_request: https://github.com/python/cpython/pull/29367 ___ Python tracker ___

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by Ned Deily : -- pull_requests: +27629 pull_request: https://github.com/python/cpython/pull/29372 ___ Python tracker ___

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by Ned Deily : -- pull_requests: +27628 pull_request: https://github.com/python/cpython/pull/29371 ___ Python tracker ___

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by Ned Deily : -- pull_requests: +27627 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/29369 ___ Python tracker ___

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: OK. Shift-Command-S works. I will attach the fossil diff which should have enough context to indicate where to add the one new line. Then I will merge this change into the 8.6.12 release candidate -- Added file:

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: > When you press Command-S on a non-new edit window you do see the flash of the Save menu, so it would appear that a dialog was meant to appear, and there is no indication of why it did not. Yes, that is long-standing behavior of IDLE on macOS; I just verified

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: Yes that is what I meant. So I guess everything may be OK now. I did verify that the Tk demo can repeatedly open file save dialogs. When you press Command-S on a non-new edit window you do see the flash of the Save menu, so it would appear that a dialog was

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: > Subsequent Command-S presses do not cause the file dialog to reappear. Do you mean Command-S after modifying an IDLE edit window that has already been Save (or was Opened, not New)? In that case, the file dialog shouldn't appear: it saves to the existing file.

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: I found the cause of the zombie dialog window. I was supposed to call [parent endSheet] after calling [parent beginSheet]. Adding that stops the window from reappearing. But it does not solve the whole problem. Subsequent Command-S presses do not cause the

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: Alas, the celebration was premature. Shortly after posting msg405488 above, I installed the updated 3.10.0 on yet another macOS system and, on this one, I observed a problem: under some circumstances at least, the Save dialog window becomes orphaned and does not

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: As of 2021-11-02, the macOS installer file on python.org for the 3.10.0 release has been updated to include an updated Tk library that includes this fix. All other files installed by the installer are the same as in the original 3.10.0 installer, other than the

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: Thanks for the heads-up about the "10.16" issue, Marc. Sorry I missed that aspect when reviewing your fix as we had run into that "feature" before. I guess the idea was that it made it easier during the early days of Big Sur to build some products that were not

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: Heads up! A strange Apple quirk has been identified which could affect the file dialog behavior if the Tk library is compiled on macOS 10.XX and used on macOS 11 or 12. (I am not sure if this applies here.) The fix for the broken file dialog was to use

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by Sam James : -- nosy: +thesamesam ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Łukasz Langa added the comment: New changeset f19c1a115f782036edac306de0f3f9968c1e1fd6 by Miss Islington (bot) in branch '3.8': bpo-44828: Avoid tkinter file dialog failure on macOS 12 Monterey (GH-29276) (GH-29279)

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

miss-islington added the comment: New changeset 8e5e74e3049875e9d834fe4408263676fe21e890 by Miss Islington (bot) in branch '3.9': bpo-44828: Avoid tkinter file dialog failure on macOS 12 Monterey (GH-29276) https://github.com/python/cpython/commit/8e5e74e3049875e9d834fe4408263676fe21e890

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

miss-islington added the comment: New changeset 54579087c69f95531cbe7a97401c67f104a3e52f by Miss Islington (bot) in branch '3.10': bpo-44828: Avoid tkinter file dialog failure on macOS 12 Monterey (GH-29276) https://github.com/python/cpython/commit/54579087c69f95531cbe7a97401c67f104a3e52f

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by miss-islington : -- pull_requests: +27542 pull_request: https://github.com/python/cpython/pull/29279 ___ Python tracker ___

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by miss-islington : -- nosy: +miss-islington nosy_count: 16.0 -> 17.0 pull_requests: +27540 pull_request: https://github.com/python/cpython/pull/29277 ___ Python tracker

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: New changeset be8318be05e1a874215fa75b8845ede74b2c69b6 by Ned Deily in branch 'main': bpo-44828: Avoid tkinter file dialog failure on macOS 12 Monterey (GH-29276) https://github.com/python/cpython/commit/be8318be05e1a874215fa75b8845ede74b2c69b6 --

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by miss-islington : -- pull_requests: +27541 pull_request: https://github.com/python/cpython/pull/29278 ___ Python tracker ___

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: That is great news! I will now merge the changes into the Tk core-8-6-branch and core-8-6-12-rc branches. -- ___ Python tracker ___

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by Ned Deily : -- pull_requests: +27539 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29276 ___ Python tracker ___

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: > Here is one more attempt, hopefully the final one. I think we have a winner! The issues I've seen all seem to be resolved in this latest round. Thank you, Marc! For the record, my testing for this has been very rudimentary manual testing so I'm certainly not

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: Hi Ned. Here is one more attempt, hopefully the final one. I tested with IDLE on 10.14 (VM), 10.15(hard), 11(hard), 12(VM). I used Python 3.10.0. I replaced libtk8.6.dylib with the Tk lib compiled from the tip of the macosx_filedialog branch. I could not

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: Hmmm, the 10.15 segfault seems to occur when writing the filename into the entry widget on the dialog. So maybe it is actually an issue with reference counting an NSString. I will have to look at that more carefully. --

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: Thanks for doing all the testing, Ned. I guess that the path forward is now clear. I will revert to the 8.6.11 code for 10.15 and earlier and use the new code for 11 and later. Of course the 8.6.11 code already has two cases, for 10.14 and earlier and 10.15

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by Ned Deily : Added file: https://bugs.python.org/file50401/Python_2021-10-27-231507_pyb15.crash ___ Python tracker ___ ___

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by Ned Deily : Added file: https://bugs.python.org/file50400/Python_2021-10-27-231308_pyb15.crash ___ Python tracker ___ ___

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: Thanks for the quick response, Marc. The results of testing were mixed. The good news: the new version did seem to solve the Monterey problem of the "UFO" and the loss of keyboard focus. However, the new version causes new problems on other releases. - On 10.14

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: Hi Ned, I think this problem is fixed now in the tip of the Tk macosx_filedialog branch. I am attaching the tkMacOSXDialog.c file from that branch. I think you should be able to just replace the version in 8.6.11 and be able to build a working version. I

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Marc Culler added the comment: Thanks, Ned, for finding my mistake which you generously called a typo. I have fixed the inequality in the Tk fossil repository. Incidentally, there is now a core-8-6-12-rc branch of Tk, also containing the fix. So it should not be too long before 8.6.12 is

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Change by Ned Deily : -- assignee: terry.reedy -> ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44828] tkinter.filedialog linked with Tk 8.6.11 crashes on macOS 12 Monterey, breaking IDLE saves

Ned Deily added the comment: Marc, thanks for providing the patch for Tk. There are some issues with it, though, at least when used with IDLE. I built a Python 3.10.0+ universal2 installer, like what we provide on python.org, with just the updated Tk and tested it on macOS 10.9, 10.13,