[issue45017] move opcode-related logic from modulefinder to dis

Change by Irit Katriel : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue45017] move opcode-related logic from modulefinder to dis

Irit Katriel added the comment: New changeset 04676b69466d2e6d2903f1c6879d2cb292721455 by Irit Katriel in branch 'main': bpo-45017: move opcode-related logic from modulefinder to dis (GH-28246) https://github.com/python/cpython/commit/04676b69466d2e6d2903f1c6879d2cb292721455 -- ___

[issue45017] move opcode-related logic from modulefinder to dis

Irit Katriel added the comment: I agree, I’ll make them private. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue45017] move opcode-related logic from modulefinder to dis

Batuhan Taskaya added the comment: Does find_imports/find_store_names have to be public? I think the relocation is fine, but making them public without any use case from outside can be avoided at least for now. -- nosy: +BTaskaya ___ Python tracke

[issue45017] move opcode-related logic from modulefinder to dis

Irit Katriel added the comment: The modulefinder module shouldn’t know what sequence of opcodes the compiler emits for import. For example, if the compiler changes you get a fairly high level test failure that you need to debug. After this refactor the test failure is more obviously pointin

[issue45017] move opcode-related logic from modulefinder to dis

Serhiy Storchaka added the comment: What is wrong with this? Is such logic used in the dis module or any other module outside modulefinder? -- nosy: +serhiy.storchaka ___ Python tracker

[issue45017] move opcode-related logic from modulefinder to dis

Change by Irit Katriel : -- keywords: +patch pull_requests: +2 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28246 ___ Python tracker ___ ___

[issue45017] move opcode-related logic from modulefinder to dis

Change by Guido van Rossum : -- nosy: +gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue45017] move opcode-related logic from modulefinder to dis

New submission from Irit Katriel : The modulefinder library module has logic that understands particular opcodes (such as the scan_opcodes method). This should be encapsulated in the dis module, and modulefinder should not process opcodes directly. -- components: Library (Lib) message