[issue45144] Use subtests in test_peepholer

2021-09-10 Thread Łukasz Langa
Łukasz Langa added the comment: We can refactor the tests to your new functionality once it's ready, Serhiy. In the mean time, this is fixed! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue45144] Use subtests in test_peepholer

2021-09-10 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset f8d624d6a571d6e773f53ad80aa93face7e8395b by Irit Katriel in branch 'main': bpo-45144: use subTests in test_peepholer (GH-28247) https://github.com/python/cpython/commit/f8d624d6a571d6e773f53ad80aa93face7e8395b -- nosy: +lukasz.langa

[issue45144] Use subtests in test_peepholer

2021-09-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I am currently working on a feature which can be better in these cases that subTest(). It will allow to reduce the indentation level instead of increasing it. -- nosy: +serhiy.storchaka ___ Python tracker

[issue45144] Use subtests in test_peepholer

2021-09-08 Thread Irit Katriel
Change by Irit Katriel : -- keywords: +patch pull_requests: +26667 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28247 ___ Python tracker ___

[issue45144] Use subtests in test_peepholer

2021-09-08 Thread Irit Katriel
New submission from Irit Katriel : test_peepholer has many tests that loop over test cases. Identifying them as subtests will make them easier to work with when something breaks. -- components: Tests messages: 401428 nosy: iritkatriel priority: normal severity: normal status: open