[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

2013-10-12 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed versions: -Python 3.2 ___ Python tracker ___ __

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

2013-10-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 142c62a490ce by Antoine Pitrou in branch 'default': Issue #4555: All exported C symbols are now prefixed with either "Py" or "_Py". http://hg.python.org/cpython/rev/142c62a490ce -- nosy: +python-dev ___ P

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

2012-12-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: This very simple patch should certainly be applied. -- assignee: -> dmalcolm stage: patch review -> commit review versions: +Python 2.7 -Python 2.6 ___ Python tracker _

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

2012-11-27 Thread Martin v . Löwis
Martin v. Löwis added the comment: I'd like to focus this issue; it has been open long enough, and deserves to get closed once the original issue is resolved - which was that "make smelly" reports symbols. I think dmalcolm's patch is quite a good start for that. It may well be that other modul

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

2012-11-26 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- stage: test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

2012-11-26 Thread Christian Heimes
Christian Heimes added the comment: For Python 3.3 and 3.4 make smelly still lists two exported symbols. asdl_int_seq_new asdl_seq_new Do we have to check the modules, too? Some of them like _ctypes and _decimal export a lot of symbols. Here is a small shell snippet for Makefile. for MOD

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

2010-07-20 Thread Dave Malcolm
Dave Malcolm added the comment: Patch to py3k which adds the "_Py" prefix to the four listed symbols. With this, the output from "make smelly" is clean (odorless, perhaps?). However, adding _Py does seem to go against this comment in Include/asdl.h: /* It would be nice if the code generated by

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

2010-07-20 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- title: Smelly exports -> Smelly exports (global symbols in python not prefixed with Py or _Py) ___ Python tracker ___ ___