[issue45720] Remove shlwapi dependency on Windows

Steve Dower added the comment: New changeset 5017306c8732b3ceda878db13088f8c2cf0c5e71 by Miss Islington (bot) in branch '3.9': bpo-45720: Drop references to shlwapi.dll on Windows (GH-29417) https://github.com/python/cpython/commit/5017306c8732b3ceda878db13088f8c2cf0c5e71 --

[issue45720] Remove shlwapi dependency on Windows

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue45720] Remove shlwapi dependency on Windows

Steve Dower added the comment: New changeset 804ea41211b042fa20c3cd8c0457bbfa3873128a by Steve Dower in branch '3.10': bpo-45720: Drop references to shlwapi.dll on Windows (GH-29417) https://github.com/python/cpython/commit/804ea41211b042fa20c3cd8c0457bbfa3873128a --

[issue45720] Remove shlwapi dependency on Windows

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +27690 pull_request: https://github.com/python/cpython/pull/29436 ___ Python tracker

[issue45720] Remove shlwapi dependency on Windows

Change by Steve Dower : -- pull_requests: +27689 pull_request: https://github.com/python/cpython/pull/29435 ___ Python tracker ___

[issue45720] Remove shlwapi dependency on Windows

Steve Dower added the comment: New changeset a4774f42e35861c4bb16928cffb011c2d8a285ac by Steve Dower in branch 'main': bpo-45720: Drop references to shlwapi.dll on Windows (GH-29417) https://github.com/python/cpython/commit/a4774f42e35861c4bb16928cffb011c2d8a285ac --

[issue45720] Remove shlwapi dependency on Windows

Eryk Sun added the comment: > I also don't actually see gdi32 being transitively loaded as > claimed in the Twitter thread, even back to 3.8. So presumably > there's something else going on to cause that issue. Since Windows XP, shlwapi.dll has increasingly made use of delay loading, but up

[issue45720] Remove shlwapi dependency on Windows

Steve Dower added the comment: FTR, I see about 1-1.5ms improvement (using timeit to do a check_call) out of ~32ms total startup time. I also don't actually see gdi32 being transitively loaded as claimed in the Twitter thread, even back to 3.8. So presumably there's something else going on

[issue45720] Remove shlwapi dependency on Windows

Change by Steve Dower : -- nosy: +eryksun ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45720] Remove shlwapi dependency on Windows

Change by Steve Dower : -- keywords: +patch pull_requests: +27670 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29417 ___ Python tracker ___

[issue45720] Remove shlwapi dependency on Windows

New submission from Steve Dower : According to https://twitter.com/BruceDawson0xB/status/1455714820485894151?s=20 there are some serious performance implications from referencing shlwapi.dll. It turns out, we only use it for one native path calculation function, which is easily replaceable