[issue45747] Detect dbm and gdbm dependencies in configure.ac

2022-04-04 Thread Oleg Iarygin
Change by Oleg Iarygin : -- nosy: +arhadthedev nosy_count: 4.0 -> 5.0 pull_requests: +30359 pull_request: https://github.com/python/cpython/pull/32299 ___ Python tracker ___ __

[issue45747] Detect dbm and gdbm dependencies in configure.ac

2021-11-10 Thread Christian Heimes
Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45747] Detect dbm and gdbm dependencies in configure.ac

2021-11-10 Thread Christian Heimes
Christian Heimes added the comment: New changeset 0a9f69539be27acf1cddf1b58d02a88d02e5008d by Christian Heimes in branch 'main': bpo-45747: Detect gdbm/dbm dependencies in configure (GH-29467) https://github.com/python/cpython/commit/0a9f69539be27acf1cddf1b58d02a88d02e5008d --

[issue45747] Detect dbm and gdbm dependencies in configure.ac

2021-11-09 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: AC_SEARCH_LIBS() will search libc before checking external libraries, FWIW. -- nosy: +erlendaasland ___ Python tracker ___ ___

[issue45747] Detect dbm and gdbm dependencies in configure.ac

2021-11-08 Thread Christian Heimes
Christian Heimes added the comment: Thanks Ronald. I was not aware that macOS has dbm_open in libc. AC_CHECK_LIB() always tries to link with an external library. The macro should skip the symbol from libc. Could you please run the PR locally and upload your config.log? -- _

[issue45747] Detect dbm and gdbm dependencies in configure.ac

2021-11-08 Thread Ronald Oussoren
Ronald Oussoren added the comment: dbm_open is in libc on macOS. likely due to being in SUSv2. The implementation in libc appears to be suboptimal (for example: issue33074), although I wouldn't teach configure.ac to ignore the system version of the library. -- nosy: +ronaldoussoren

[issue45747] Detect dbm and gdbm dependencies in configure.ac

2021-11-08 Thread Christian Heimes
Christian Heimes added the comment: Pablo's macOS ARM64 buildbot does not find libdb-5.3 although it has db.h: https://buildbot.python.org/all/#/builders/721/builds/97/steps/2/logs/stdio macOS X86-64 buildbot has libdb-5.3: https://buildbot.python.org/all/#/builders/311/builds/332/steps/2/lo

[issue45747] Detect dbm and gdbm dependencies in configure.ac

2021-11-08 Thread Christian Heimes
Change by Christian Heimes : -- keywords: +patch pull_requests: +27720 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29467 ___ Python tracker ___

[issue45747] Detect dbm and gdbm dependencies in configure.ac

2021-11-08 Thread Christian Heimes
New submission from Christian Heimes : setup.py jumps through hoops to detect gdbm, gdbm_compat, ndbm, and bdb (libdb) build dependencies. I propose to simplify our support matrix and detect all dependencies in configure.ac. gdbmmodule.c uses gdbm_open() API, which is provided by gdbm.h and l