[issue4604] close() seems to have limited effect

Changes by Antoine Pitrou : -- resolution: accepted -> fixed status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mail

[issue4604] close() seems to have limited effect

Antoine Pitrou added the comment: Expanded the test a bit and committed the patch in r68454. Thanks! -- resolution: -> accepted stage: patch review -> committed/rejected status: open -> pending versions: -Python 3.1 ___ Python tracker

[issue4604] close() seems to have limited effect

Dmitry Vasiliev added the comment: Attached more generic version of the patch. -- nosy: +hdima Added file: http://bugs.python.org/file12450/io_fixes.patch ___ Python tracker ___

[issue4604] close() seems to have limited effect

Changes by Martin v. Löwis : -- priority: deferred blocker -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue4604] close() seems to have limited effect

Changes by Martin v. Löwis <[EMAIL PROTECTED]>: -- priority: release blocker -> deferred blocker ___ Python tracker <[EMAIL PROTECTED]> ___

[issue4604] close() seems to have limited effect

Skip Montanaro <[EMAIL PROTECTED]> added the comment: Amaury> - It should use Amaury>self._checkClosed() Amaury> which already raises the same exception with the same message. I think some other places will need this change then. Note that I don't know the io code at all. I was jus

[issue4604] close() seems to have limited effect

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: - The patch corrects a specific case, but not others: for example if the file is opened in "r" (text) mode. There are also other methods to test: peek(), read1()... - It should use self._checkClosed() which already raises the same e

[issue4604] close() seems to have limited effect

Changes by Skip Montanaro <[EMAIL PROTECTED]>: -- stage: needs patch -> patch review ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Pyth

[issue4604] close() seems to have limited effect

Changes by Skip Montanaro <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file12305/iobug.diff ___ Python tracker <[EMAIL PROTECTED]> ___

[issue4604] close() seems to have limited effect

Skip Montanaro <[EMAIL PROTECTED]> added the comment: Here's a minimal patch to BufferedReader.read() which causes the test to pass. I will leave it for smarter people to decided whether or not all the other read() methods need the same test. Added file: http://bugs.python.org/file12309/io.patc

[issue4604] close() seems to have limited effect

Skip Montanaro <[EMAIL PROTECTED]> added the comment: fixed patch. I'm still a bit clumsy with the assertRaises stuff. Added file: http://bugs.python.org/file12306/iobug.diff ___ Python tracker <[EMAIL PROTECTED]> _

[issue4604] close() seems to have limited effect

Changes by Skip Montanaro <[EMAIL PROTECTED]>: -- stage: test needed -> needs patch ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Pytho

[issue4604] close() seems to have limited effect

Skip Montanaro <[EMAIL PROTECTED]> added the comment: Here's a test case (diff against Lib/test/test_io.py). This fails for me on OS X 10.5.5 with the tip of the py3k branch. -- keywords: +patch Added file: http://bugs.python.org/file12305/iobug.diff ___

[issue4604] close() seems to have limited effect

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Indeed, it seems to happen if you first call read() before calling close(). -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> __

[issue4604] close() seems to have limited effect

Changes by Christian Heimes <[EMAIL PROTECTED]>: -- components: +Extension Modules, Library (Lib) -Interpreter Core nosy: +christian.heimes priority: -> release blocker stage: -> test needed versions: +Python 3.1 ___ Python tracker <[EMAIL PROTECTED

[issue4604] close() seems to have limited effect

New submission from Skip Montanaro <[EMAIL PROTECTED]>: Seems like file.close() in 3.0 isn't much of a barrier to further reading: % python3.0 Python 3.0rc3+ (py3k:67338M, Nov 22 2008, 06:47:23) [GCC 4.0.1 (Apple Inc. build 5465)] on darwin Type "help", "copyright", "credits" or "license" for m