[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Change by Tal Einat : -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Tal Einat added the comment: Thanks for this, Erlend! -- stage: resolved -> patch review ___ Python tracker ___ ___

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Tal Einat added the comment: New changeset b29aa71090e4dd34900660ecca8bb62667440f41 by Miss Islington (bot) in branch '3.9': [3.9] bpo-46261: Update `sqlite3.Cursor.lastrowid` docs (GH-30407) https://github.com/python/cpython/commit/b29aa71090e4dd34900660ecca8bb62667440f41 --

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Tal Einat added the comment: New changeset 987fba102e909229dd2aa1a6115aa28d514c1818 by Miss Islington (bot) in branch '3.10': bpo-46261: Update `sqlite3.Cursor.lastrowid` docs (GH-30407) https://github.com/python/cpython/commit/987fba102e909229dd2aa1a6115aa28d514c1818 --

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Tal Einat added the comment: New changeset b6aa38f1ca79600f2ab46ac114ff36461a19c4a3 by Erlend Egeberg Aasland in branch 'main': bpo-46261: Update `sqlite3.Cursor.lastrowid` docs (GH-30407) https://github.com/python/cpython/commit/b6aa38f1ca79600f2ab46ac114ff36461a19c4a3 -- nosy:

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Change by miss-islington : -- pull_requests: +28691 pull_request: https://github.com/python/cpython/pull/30488 ___ Python tracker ___

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +28690 pull_request: https://github.com/python/cpython/pull/30487 ___ Python tracker

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Erlend E. Aasland added the comment: FYI: https://sqlite.org/c3ref/last_insert_rowid.html -- ___ Python tracker ___ ___

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +28613 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30407 ___ Python tracker

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Erlend E. Aasland added the comment: I also suggest to add a note about tables without rowids, quoting the SQLite docs: Inserts into WITHOUT ROWID tables are not recorded. -- ___ Python tracker

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

Erlend E. Aasland added the comment: Oh, and the docs says that lastrowid "provides the rowid of the last modified row". This is not true; it provides the row id of the last _inserted_ row. -- ___ Python tracker

[issue46261] [doc] fix inaccuracies in sqlite3.Cursor.lastrowid docs

New submission from Erlend E. Aasland : The sqlite3 docs say that lastrowid is set to None after executemany(), or after execute()'ing statements that are not INSERTs or REPLACEs. This is not true; in those cases, lastrowid is preserved. lastrowid is only None in a pristine cursor.