[issue46289] AST: FomattedValue conversion's default value should be -1

Change by Batuhan Taskaya : -- stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.11 -Python 3.9 ___ Python tracker ___ ___

[issue46289] AST: FomattedValue conversion's default value should be -1

miss-islington added the comment: New changeset bea3f42bb7c360921f864949ef7472a7ecb02cd3 by Miss Islington (bot) in branch '3.10': bpo-46289: Make conversion of FormattedValue not optional on ASDL (GH-30467) https://github.com/python/cpython/commit/bea3f42bb7c360921f864949ef7472a7ecb02cd3 -

[issue46289] AST: FomattedValue conversion's default value should be -1

Change by miss-islington : -- pull_requests: +28672 pull_request: https://github.com/python/cpython/pull/30469 ___ Python tracker ___ __

[issue46289] AST: FomattedValue conversion's default value should be -1

Pablo Galindo Salgado added the comment: I would say yes, for consistency. It doesn't have any effects on user code that I am aware -- ___ Python tracker ___

[issue46289] AST: FomattedValue conversion's default value should be -1

Batuhan Taskaya added the comment: Should we backport this? On Sat, Jan 8, 2022, 12:05 AM miss-islington wrote: > > miss-islington added the > comment: > > > New changeset d382f7ee0b98e4ab6ade9384268f25c06be462ad by Batuhan Taskaya > in branch 'main': > bpo-46289: Make conversion of Formatt

[issue46289] AST: FomattedValue conversion's default value should be -1

miss-islington added the comment: New changeset d382f7ee0b98e4ab6ade9384268f25c06be462ad by Batuhan Taskaya in branch 'main': bpo-46289: Make conversion of FormattedValue not optional on ASDL (GH-30467) https://github.com/python/cpython/commit/d382f7ee0b98e4ab6ade9384268f25c06be462ad --

[issue46289] AST: FomattedValue conversion's default value should be -1

Change by Batuhan Taskaya : -- keywords: +patch pull_requests: +28670 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30467 ___ Python tracker ___

[issue46289] AST: FomattedValue conversion's default value should be -1

Pablo Galindo Salgado added the comment: I think A is the best option -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue46289] AST: FomattedValue conversion's default value should be -1

Lysandros Nikolaou added the comment: I agree that A is probably the way to go. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue46289] AST: FomattedValue conversion's default value should be -1

Batuhan Taskaya added the comment: ASDL technically allows it to be None though neither compiler nor ast.unparse can work with it at this moment. > FormattedValue(expr value, int? conversion, expr? format_spec) https://github.com/python/cpython/blob/b127e70a8a682fe869c22ce04c379bd85a00db67/P

[issue46289] AST: FomattedValue conversion's default value should be -1

Change by Pablo Galindo Salgado : -- nosy: +BTaskaya ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue46289] AST: FomattedValue conversion's default value should be -1

New submission from Anh71me : An unexpected behavior lookup: ```python >>> ast.FormattedValue(ast.Str('ss')).conversion >>> ast.unparse(ast.FormattedValue(ast.Str('ss'))) Traceback (most recent call last): File "", line 1, in File "/usr/local/lib/python3.9/ast.py", line 1564, in unparse