[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

Eric Snow added the comment: I'm glad we were able to figure it out relatively quickly...and without any big headaches. :) And thanks for testing against the alpha releases!!! You're having a positive impact. -- resolution: -> not a bug ___ Pyt

[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

Quentin Pradet added the comment: Oh my god. You're right, I had a cffi wheel compiled for Python 3.11 before that commit. But the wheel was not coming from PyPI, it was coming from pip's own cache! And we recently enabled pip's cache in GitHub Actions too. So the wheel compiled locally for a

[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

Eric Snow added the comment: It looks like PyThreadState.async_exc is getting set to 0x01 somewhere. There isn't any code like that in https://github.com/python/cpython/commit/32a67246b0d1e08cd50fc3bfa58052cfeb515b2e. However, the struct layout of PyThreadState did change slightly in that

[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

Eric Snow added the comment: FYI, I get the crash with just: pytest test/contrib/test_pyopenssl.py::TestHTTPS::test_verify_none_and_bad_fingerprint -- ___ Python tracker __

[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

Eric Snow added the comment: > pip install -r dev-requirements.txt > pip install ".[socks,secure,brotli]" > pytest I was able to reproduce the crash with these steps. Thanks! -- ___ Python tracker

[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

Quentin Pradet added the comment: We haven't opened an issue for this, but discussed it in Discord, sorry. It also does not always crash on GitHub Actions. Here's an example of a crash: https://github.com/urllib3/urllib3/runs/4740730329?check_suite_focus=true If nox can't find your Python ve

[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

Eric Snow added the comment: It looks like the urllib3 CI is passing for 3.11.0a3: https://github.com/urllib3/urllib3/runs/4762856431 (Ubuntu 3.11-dev test-3.11). Is there a urllib3 issue number you could point me at? -- ___ Python tracker

[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

Eric Snow added the comment: I must be missing something. Here is what I did: ``` $ cd cpython $ git checkout main $ make -j8 $ ./python -v venv ../venv-urllib3 $ cd .. $ git clone https://github.com/urllib3/urllib3 $ cd urllib3 $ ../venv-urllib3/bin/python3 -m pip install nox $ ../venv-urlli

[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

Quentin Pradet added the comment: Yes, exactly. `pip install nox && nox -Rs test-3.11`. My reproducer is still too big to be useful, and I failed to reproduce this on Docker. If you can't reproduce, I'll work on the reproducer more. Thanks! -- ___

[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

Eric Snow added the comment: I'll look into this today. To reproduce, I should run the urllib3 test suite? -- assignee: -> eric.snow stage: -> needs patch ___ Python tracker __

[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

Quentin Pradet added the comment: Sorry, I pasted the same crash twice. Here's the segmentation fault in `selectors`: ``` = test session starts ===

[issue46320] runtime/interp/thread state refactoring leads to segmentation fault

New submission from Quentin Pradet : Since https://github.com/python/cpython/commit/32a67246b0d1e08cd50fc3bfa58052cfeb515b2e which was introduced through https://bugs.python.org/issue46008 and shipped as part of alpha 3, the urllib3 test suite reliably crashes on Fedora 35 (ie. gives a segfa