[issue46386] Improve `test_typing::test_immutability_by_copy_and_pickle`

Dong-hee Na added the comment: Thank you @sobolevn ! -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue46386] Improve `test_typing::test_immutability_by_copy_and_pickle`

Dong-hee Na added the comment: New changeset 09087b8519316608b85131ee7455b664c00c38d2 by Nikita Sobolev in branch 'main': bpo-46386: improve `test_typing:test_immutability_by_copy_and_pickle` (GH-30613) https://github.com/python/cpython/commit/09087b8519316608b85131ee7455b664c00c38d2

[issue46386] Improve `test_typing::test_immutability_by_copy_and_pickle`

Nikita Sobolev added the comment: Thank you, Jelle. Will send a PR to typing_extensions today as well :) -- ___ Python tracker ___

[issue46386] Improve `test_typing::test_immutability_by_copy_and_pickle`

Jelle Zijlstra added the comment: The additional tests would also be useful to have in https://github.com/python/typing/tree/master/typing_extensions if you're interested. -- nosy: +Jelle Zijlstra ___ Python tracker

[issue46386] Improve `test_typing::test_immutability_by_copy_and_pickle`

Change by Nikita Sobolev : -- keywords: +patch pull_requests: +28816 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30613 ___ Python tracker ___

[issue46386] Improve `test_typing::test_immutability_by_copy_and_pickle`

Change by Alex Waygood : -- nosy: +gvanrossum, kj ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46386] Improve `test_typing::test_immutability_by_copy_and_pickle`

New submission from Nikita Sobolev : There are several problems with this test: https://github.com/python/cpython/blob/d02c5e9b55a8651b7d396ac3f2bdedf1fc1780b5/Lib/test/test_typing.py#L2130 1. It does not test all `pickle` protocols 2. It does not test newly added `ParamSpec` (probably others,