[issue46396] Typing: test invalid usages of `Concatenate`

2022-01-22 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Let's change typing_extensions.py too in the same way. Speaking of typing-extensions, it'd be great if someone could review https://github.com/python/typing/pull/963 :) -- ___ Python tracker

[issue46396] Typing: test invalid usages of `Concatenate`

2022-01-22 Thread Nikita Sobolev
Nikita Sobolev added the comment: With this change `typing.py` and `typing_extensions.py` will have different logic: https://github.com/python/typing/blob/523cf0233edc7a29502fbd30dc6bf641a7408e16/typing_extensions/src/typing_extensions.py#L1805-L1811 Jelle, what should we do? --

[issue46396] Typing: test invalid usages of `Concatenate`

2022-01-22 Thread Nikita Sobolev
Nikita Sobolev added the comment: > So maybe that code could just be removed? I see this trend in typing.py :) I think it makes sense to make all new types (I still consider `ParamSpec` and `Concatenate` as new, desipte the fact they are already released in 3.10) as flexible as possible.

[issue46396] Typing: test invalid usages of `Concatenate`

2022-01-21 Thread Guido van Rossum
Guido van Rossum added the comment: Arguably the runtime should not check for incorrect calls to Concatenate. That's the job of static type checkers. So maybe that code could just be removed? (We don't bother checking things like list[0] either.) --

[issue46396] Typing: test invalid usages of `Concatenate`

2022-01-21 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: Invalid usage of `Concatenate` is not covered at all -> Typing: test invalid usages of `Concatenate` ___ Python tracker ___