[issue4653] Patch to fix typos for Py3K

2011-06-12 Thread Terry J. Reedy
Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 3.3 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4653 ___ ___

[issue4653] Patch to fix typos for Py3K

2010-05-27 Thread Alexander Belopolsky
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: I don't run Windows either but I believe sizeof(char) == 1 is guaranteed by the C standard, so the first report (Python/dynload_win.c) is invalid. The last two appear to be valid [1], and a common mistake. [2] Unit tests

[issue4653] Patch to fix typos for Py3K

2010-05-27 Thread Alexander Belopolsky
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: Strike my comment about Python/dynload_win.c - I was looking at the trunk version instead of py3k. In py3k theInfo is wchar_t and patch seems to be valid. -- ___ Python

[issue4653] Patch to fix typos for Py3K

2010-05-13 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: I fixed the typo in pythonrun.c: r81156. I don't use Windows, so I cannot review the other fixes. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4653

[issue4653] Patch to fix typos for Py3K

2010-05-12 Thread STINNER Victor
Changes by STINNER Victor victor.stin...@haypocalc.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4653 ___ ___

[issue4653] Patch to fix typos for Py3K

2010-05-11 Thread Terry J. Reedy
Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 3.2 -Python 3.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4653 ___ ___

[issue4653] Patch to fix typos for Py3K

2008-12-18 Thread Johnny Lee
Johnny Lee typo...@gmail.com added the comment: It's difficult to really test such errors. When I can't control the called function, I usually step through the code in a debugger and change the result variable in question to the appropriate value to see if the code handles failed function

[issue4653] Patch to fix typos for Py3K

2008-12-16 Thread Mark Dickinson
Mark Dickinson dicki...@gmail.com added the comment: It looks to me as though all these are valid, and the patch should be applied to py3k and the 3.0 maintenance branch. Minor nit: the sizeof(theInfo) line exceeds 79 characters, in violation of PEP 7. Is there any core developer who's in a

[issue4653] Patch to fix typos for Py3K

2008-12-16 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: It's difficult to really test such errors. Moreover, on the top of the bdist_wininst files, a comment says loudly: IF CHANGES TO THIS FILE ARE CHECKED INTO PYTHON CVS, THE RECOMPILED BINARIES MUST BE CHECKED IN AS WELL! --

[issue4653] Patch to fix typos for Py3K

2008-12-16 Thread Johnny Lee
Changes by Johnny Lee typo...@gmail.com: Removed file: http://bugs.python.org/file12335/py30diff.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4653 ___

[issue4653] Patch to fix typos for Py3K

2008-12-16 Thread Johnny Lee
Johnny Lee typo...@gmail.com added the comment: attached modified diff patch so line length =79 chars Added file: http://bugs.python.org/file12374/py30dif2.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4653

[issue4653] Patch to fix typos for Py3K

2008-12-13 Thread Antoine Pitrou
Antoine Pitrou pit...@free.fr added the comment: I don't know Windows APIs but the pythonrun.c bug is genuine. -- nosy: +pitrou priority: - high type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4653

[issue4653] Patch to fix typos for Py3K

2008-12-13 Thread Johnny Lee
Johnny Lee typo...@gmail.com added the comment: Here are the URLs to the MSDN documentation for CreateFileMapping and FormatMessage[A|W]: http://msdn.microsoft.com/en-us/library/aa366537.aspx http://msdn.microsoft.com/en-us/library/ms679351.aspx For CreateFileMapping(), from the Return Value

[issue4653] Patch to fix typos for Py3K

2008-12-13 Thread Johnny Lee
Johnny Lee typo...@gmail.com added the comment: For the dynload_win.c typo, it's technically a possible buffer overflow, but you'd need to find an error that had an error message that's longer than 259 chars. In pythonrun.c, the if statements for fout and ferr and almost identical. Probably

[issue4653] Patch to fix typos for Py3K

2008-12-12 Thread Johnny Lee
New submission from Johnny Lee typo...@gmail.com: I ran my typo.pl perl script that locates possible C/C++ typos. I found four that looked valid. Two of the typos were in the Python directory {pythonrun.c, dynload_win.c}, two were in PC/bdist_wininst {install.c, extract.c}.