[issue46775] [Windows] OSError should unconditionally call winerror_to_errno

Change by Dong-hee Na : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue46775] [Windows] OSError should unconditionally call winerror_to_errno

miss-islington added the comment: New changeset d04a21344ae69c66f5a6df69ee6fa6988a69b89d by Miss Islington (bot) in branch '3.9': bpo-46775: OSError should call winerror_to_errno unconditionally on Windows (GH-32179)

[issue46775] [Windows] OSError should unconditionally call winerror_to_errno

miss-islington added the comment: New changeset 1f2ec4cef1804cda9d2df99a318373b2982919e9 by Miss Islington (bot) in branch '3.10': bpo-46775: OSError should call winerror_to_errno unconditionally on Windows (GH-32179)

[issue46775] [Windows] OSError should unconditionally call winerror_to_errno

Steve Dower added the comment: I'm still not convinced we should backport. Has anyone looked through to see whether this will actually affect any high valued error codes today? -- ___ Python tracker

[issue46775] [Windows] OSError should unconditionally call winerror_to_errno

Change by miss-islington : -- pull_requests: +30276 pull_request: https://github.com/python/cpython/pull/32199 ___ Python tracker ___

[issue46775] [Windows] OSError should unconditionally call winerror_to_errno

Change by miss-islington : -- nosy: +miss-islington nosy_count: 6.0 -> 7.0 pull_requests: +30275 pull_request: https://github.com/python/cpython/pull/32198 ___ Python tracker

[issue46775] [Windows] OSError should unconditionally call winerror_to_errno

Steve Dower added the comment: New changeset d0c67ea0645b7ad37b867c167882a346a24de641 by Dong-hee Na in branch 'main': bpo-46775: OSError should call winerror_to_errno unconditionally on Windows (GH-32179) https://github.com/python/cpython/commit/d0c67ea0645b7ad37b867c167882a346a24de641

[issue46775] [Windows] OSError should unconditionally call winerror_to_errno

Steve Dower added the comment: Is this okay to backport? Correcting more winerror values means we'll get more subclasses raised instead of OSError (though only for obscure cases, which probably also aren't mapped, so I guess it's possible to prove that none will actually change right now).

[issue46775] [Windows] OSError should unconditionally call winerror_to_errno

Change by Dong-hee Na : -- keywords: +patch nosy: +corona10 nosy_count: 5.0 -> 6.0 pull_requests: +30257 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/32179 ___ Python tracker

[issue46775] [Windows] OSError should unconditionally call winerror_to_errno

New submission from Eryk Sun : bpo-37705 overlooked fixing the OSError constructor. oserror_parse_args() in Objects/exceptions.c should unconditionally call winerror_to_errno(), which is defined in PC/errmap.h. winerror_to_errno() maps the Winsock range 1-11999 directly, except for the