[issue46903] Crash when setting attribute with string subclass as the name (--with-pydebug)

Change by Dennis Sweeney : -- pull_requests: +29833 pull_request: https://github.com/python/cpython/pull/31718 ___ Python tracker ___ __

[issue46903] Crash when setting attribute with string subclass as the name (--with-pydebug)

Karthikeyan Singaravelan added the comment: The PR introduced some deprecation warnings in tests. ./python -Wall -m test test_unicode 0:00:00 load avg: 1.54 Run tests sequentially 0:00:00 load avg: 1.54 [1/1] test_unicode /home/karthikeyan/stuff/python/cpython/Lib/test/test_unic

[issue46903] Crash when setting attribute with string subclass as the name (--with-pydebug)

Ronald Oussoren added the comment: Your PR fixed the issue for me. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ _

[issue46903] Crash when setting attribute with string subclass as the name (--with-pydebug)

Mark Shannon added the comment: Ronald, does PR 31658 fix your issue? -- stage: patch review -> ___ Python tracker ___ ___ Python-

[issue46903] Crash when setting attribute with string subclass as the name (--with-pydebug)

Mark Shannon added the comment: New changeset 03c2a36b2bd2d4469160d1607619ee144175d753 by Mark Shannon in branch 'main': bpo-46903: Handle str-subclasses in virtual instance dictionaries. (GH-31658) https://github.com/python/cpython/commit/03c2a36b2bd2d4469160d1607619ee144175d753 --

[issue46903] Crash when setting attribute with string subclass as the name (--with-pydebug)

Change by Mark Shannon : -- keywords: +patch pull_requests: +29776 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31658 ___ Python tracker ___ ___

[issue46903] Crash when setting attribute with string subclass as the name (--with-pydebug)

Change by Inada Naoki : -- nosy: +methane ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue46903] Crash when setting attribute with string subclass as the name (--with-pydebug)

Dennis Sweeney added the comment: a8b9350964f43cb648c98c179c8037fbf3ff8a7d is the first bad commit commit a8b9350964f43cb648c98c179c8037fbf3ff8a7d Author: Mark Shannon Date: Wed Oct 13 14:19:34 2021 +0100 bpo-45340: Don't create object dictionaries unless actually needed (GH-28802)

[issue46903] Crash when setting attribute with string subclass as the name (--with-pydebug)

Ronald Oussoren added the comment: A hard crash seems wrong to me, and I'm not convinced yet that checking that the type of the attribute name is exactly string is correct. Found while debugging a crash in PyObjC's testsuite, PyObjC uses a subclass of str to represent Objective-C strings. U

[issue46903] Crash when setting attribute with string subclass as the name (--with-pydebug)

New submission from Ronald Oussoren : The script below fails with an assertion error with python 3.11a5+ (current trunk) when build with --with-pydebug: # BEGIN OF FILE class String(str): __slots__ = () name = String("hello") class Bag: pass o = Bag() setattr(o, name, 42) # END OF