[issue46943] fix[imaplib]: call Exception with string instance

SpaceOne added the comment: @iritkatriel alright, I am sorry. I created another PR: https://github.com/python/cpython/pull/31823 -- ___ Python tracker ___

[issue46943] fix[imaplib]: call Exception with string instance

Change by SpaceOne : -- pull_requests: +29920 pull_request: https://github.com/python/cpython/pull/31823 ___ Python tracker ___ ___

[issue46943] fix[imaplib]: call Exception with string instance

Irit Katriel added the comment: That happened because your PR was wrong - it contained many commits that touched many files, all of whose owners were modified. If you make the PR against the main branch, the diff will not have all those files a and they will not be notified. -- ___

[issue46943] fix[imaplib]: call Exception with string instance

SpaceOne added the comment: @iritkatriel they were automatically added by github via your `.github/CODEOWNERS` file with the `**/*imap* @python/email-team` match. And they all will also be informed by another pull request. -- _

[issue46943] fix[imaplib]: call Exception with string instance

Irit Katriel added the comment: The people subscribed to the closed pr will not receive an email about a new pr which is opened correctly. What makes you think they would? -- ___ Python tracker

[issue46943] fix[imaplib]: call Exception with string instance

SpaceOne added the comment: @iritkatriel I added a unit test to the branch. I can't create a new PR without creating a new branch. But that doesn't make much sense from a technical point. It only increases the number of existing merge requests. Also all the people subscribed to the current

[issue46943] fix[imaplib]: call Exception with string instance

Irit Katriel added the comment: @spaceone I'd suggest you create a new PR. Once many people are subscribed to a PR we don't like to reopen it and spam everyone. It would also be necessary to add a unit test. -- nosy: +iritkatriel ___ Python track

[issue46943] fix[imaplib]: call Exception with string instance

Change by Irit Katriel : -- versions: -Python 3.7, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46943] fix[imaplib]: call Exception with string instance

New submission from SpaceOne : imaplib raises an Exception with a bytes instance once (in login()) - all other places str instances are raised. Adjust the behavior of login() similar to authenticate() where self.error is called with a str instance. Especially for Python3 with strict bytes mo

[issue46943] fix[imaplib]: call Exception with string instance

Change by SpaceOne : -- keywords: +patch pull_requests: +29837 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31722 ___ Python tracker ___ ___