[issue4744] asynchat documentation needs to be more precise

R. David Murray added the comment: OK, let's close it then. If someone finds something wrong they can open a new issue. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue4744] asynchat documentation needs to be more precise

Stéphane Wirtel added the comment: For my part, you can close this issue. I have read the asynchat.rst and asynchat.py files and think the rest of the documentation is clear. -- ___ Python tracker __

[issue4744] asynchat documentation needs to be more precise

R. David Murray added the comment: If you've read through the asynchat docs and don't think any of the other mentions of string are incorrect or ambiguous, then we should close it. -- ___ Python tracker ___

[issue4744] asynchat documentation needs to be more precise

Stéphane Wirtel added the comment: Martin, About the patch of Nikita, this one has already been applied. I have checked the source. David, maybe we should close this issue. And open a new one if we find an other issue in the documentation. What do you suggest? Should I continue on this issue?

[issue4744] asynchat documentation needs to be more precise

Stéphane Wirtel added the comment: Ok, in this case, I will provide the patch On 11/23, R. David Murray wrote: > > R. David Murray added the comment: > > Yes. The docs should be accurate, even if the module is deprecated. > > -- > > ___ > Python

[issue4744] asynchat documentation needs to be more precise

R. David Murray added the comment: Yes. The docs should be accurate, even if the module is deprecated. -- ___ Python tracker ___ ___ P

[issue4744] asynchat documentation needs to be more precise

Mark Lawrence added the comment: Does it make sense to spend time updating the asychat docs when https://docs.python.org/3/library/asynchat.html states "Note. This module exists for backwards compatibility only. For new code we recommend using asyncio."? -- nosy: +BreamoreBoy ___

[issue4744] asynchat documentation needs to be more precise

Stéphane Wirtel added the comment: Hi Martin, About the patch of Nikita, I am going to rewrite it asap. Will you have time to check it ? Thanks -- Stéphane Wirtel - http://wirtel.be - @matrixise -- ___ Python tracker

[issue4744] asynchat documentation needs to be more precise

Martin Panter added the comment: I think it would be okay to keep this issue open to address the other mentions of “strings”. Nitika’s patch is missing the special --- and @@ indicator lines at the top, which is probably why it was rejected. Usually you make a patch by using a “diff” command

[issue4744] asynchat documentation needs to be more precise

Stéphane Wirtel added the comment: Ping, what's the status of this issue ? maybe we can close it and open an new one with a new description. -- ___ Python tracker ___ ___

[issue4744] asynchat documentation needs to be more precise

Changes by R. David Murray : -- Removed message: http://bugs.python.org/msg216880 ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue4744] asynchat documentation needs to be more precise

R. David Murray added the comment: The change covered by the patch (which patch rejected as garbage, by the way, I have no idea why) has already been applied by Serhiy Storchaka, apparently as a blanket change of 'empty string' to 'empty bytes object'. There are several other places in the asy

[issue4744] asynchat documentation needs to be more precise

R. David Murray added the comment: The change covered by the patch (which patch rejected as garbage, by the way, I have no idea why) has already been applied by Serhiy Storchaka, apparently as a blanked change of 'empty string' to 'empty bytes object'. There are several other places in the asy

[issue4744] asynchat documentation needs to be more precise

Nitika Agarwal added the comment: But then I have submitted another patch issue4744_3 with the corrections.Please review my patch issue4744_3.patch -- ___ Python tracker ___

[issue4744] asynchat documentation needs to be more precise

Stéphane Wirtel added the comment: In your issue4744_2.patch, the anchor contains 'asychat' and not 'asynchat'. -- ___ Python tracker ___ _

[issue4744] asynchat documentation needs to be more precise

Nitika Agarwal added the comment: @Stéphane Wirtel (matrixise) I am really sorry but i just couldn't find where have i done a typo and have written 'asychat' insstead of asynchat.Will you please help me out in pointing out my error. -- ___ Python tr

[issue4744] asynchat documentation needs to be more precise

Stéphane Wirtel added the comment: Could you review your patch, there is a mistake in the name of the project, it's asynchat and not asychat. The content seems to be right, not the reference and the title. Thank you so much for your help. -- nosy: +matrixise versions: +Python 3.5 -Pyt

[issue4744] asynchat documentation needs to be more precise

Nitika Agarwal added the comment: Hi, I hvae attached the patch for review.I am waiting for reviewal.Please review the attached patch as soon as possible. -- ___ Python tracker _

[issue4744] asynchat documentation needs to be more precise

Nitika Agarwal added the comment: Attached patch with some corrections -- Added file: http://bugs.python.org/file34526/issue4744_3.patch ___ Python tracker ___ ___

[issue4744] asynchat documentation needs to be more precise

Nitika Agarwal added the comment: Hi, Please review my patch attached.Any comments and feedback are welcome. -- keywords: +patch Added file: http://bugs.python.org/file34442/issue4744_2.patch ___ Python tracker

[issue4744] asynchat documentation needs to be more precise

Nitika Agarwal added the comment: Hi, I would like to propose a patch for this issue. -- nosy: +nitika ___ Python tracker ___ ___ Pytho

[issue4744] asynchat documentation needs to be more precise

Changes by Éric Araujo : -- versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2 ___ Python tracker ___ ___ Python-bugs-list maili

[issue4744] asynchat documentation needs to be more precise

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue4744] asynchat documentation needs to be more precise

Mark Lawrence added the comment: Is there anyone with knowledge of asynchat who could provide a patch for this? -- assignee: georg.brandl -> d...@python nosy: +BreamoreBoy, d...@python stage: -> needs patch versions: +Python 2.7, Python 3.1, Python 3.2 -Python 3.0

[issue4744] asynchat documentation needs to be more precise

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola, josiah.carlson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue4744] asynchat documentation needs to be more precise

New submission from David M. Beazley : The documentation for asynchat needs to be more precise in its use of strings vs. bytes. Unless the undocumented use_encoding attribute is set, it seems that all data should be bytes throughout (e.g., the terminator, inputs to push methods, etc.). I