Alexandre Vassalotti alexan...@peadrop.com added the comment:
Patch committed in r83740. I will make the documentation update in a separate
commit.
Thanks!
--
resolution: - accepted
stage: patch review - committed/rejected
status: open - closed
versions: -Python 2.6, Python 2.7,
Alexandre Vassalotti alexan...@peadrop.com added the comment:
Documentation added in r83741.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5077
___
Meador Inge mead...@gmail.com added the comment:
Sure. I take it you meant http://svn.python.org/projects/sandbox/trunk/2to3,
though. Is this the location that all patches for 2to3 should be produced
against?
I dropped the documentation changes b/c I did not see any docs in the 2to3
trunk.
Mark Lawrence breamore...@yahoo.co.uk added the comment:
I see too many changes with tortoisesvn to make sense of this. Could someone
with more experience please take a look, thanks.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
Alexandre Vassalotti alexan...@peadrop.com added the comment:
The patch look great. Can you update your patch to make it work against the
version of 2to3 in the sandbox (http://svn.python.org/sandbox/trunk/2to3)?
--
___
Python tracker
Meador Inge mead...@gmail.com added the comment:
Attached an updated patch with:
(1) The two review issues fixed.
(2) Merged the functionality of the initial patch into the existing
fixer in 'Lib/lib2to3/fixes/fix_operator.py' + a little
refactoring.
(3) Added matching test
Benjamin Peterson benja...@python.org added the comment:
Review:
The mappings should become static to the class or module.
The repeat2mul case doesn't handle prefixes.
--
nosy: +benjamin.peterson
versions: +Python 2.6, Python 2.7
___
Python tracker
Changes by Alexandre Vassalotti alexan...@peadrop.com:
--
title: 2to3 fixers for the removal of operator functions - 2to3 fixer for the
removal of operator functions
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5077