[issue5084] unpickling does not intern attribute names

Antoine Pitrou added the comment: Committed in r72223, r72224. Thanks! -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue5084] unpickling does not intern attribute names

Antoine Pitrou added the comment: Thanks, I'll take a look very soon. -- assignee: alexandre.vassalotti -> pitrou ___ Python tracker ___ _

[issue5084] unpickling does not intern attribute names

Changes by Antoine Pitrou : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5084] unpickling does not intern attribute names

Jake McGuire added the comment: This fell through the cracks. But the following unit test seems like it does the right thing (fails with the old module, works with the new ones). -- Added file: http://bugs.python.org/file13835/pickletester.diff ___

[issue5084] unpickling does not intern attribute names

Antoine Pitrou added the comment: (s/string/still/, of course...) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue5084] unpickling does not intern attribute names

Antoine Pitrou added the comment: Jake, are you string working on a test? -- priority: -> normal stage: -> needs patch versions: +Python 2.7, Python 3.1 ___ Python tracker ___

[issue5084] unpickling does not intern attribute names

Changes by Jake McGuire : Removed file: http://bugs.python.org/file13169/cPickle.c.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue5084] unpickling does not intern attribute names

Changes by Jake McGuire : Removed file: http://bugs.python.org/file12882/cPickle.c.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue5084] unpickling does not intern attribute names

Jake McGuire added the comment: Ugh. Clearly I didn't check to see if it worked or not, as it didn't even compile. A new diff, tested and verified to work, is attached. I'll work on creating a test. Added file: http://bugs.python.org/file13178/cPickle.c.diff __

[issue5084] unpickling does not intern attribute names

Antoine Pitrou added the comment: To give an example of what the test could check: >>> class C(object): ... def __init__(self): ...self.some_long_attribute_name = 5 ... >>> c = C() >>> c.__dict__ {'some_long_attribute_name': 5} >>> sorted(map(id, c.__dict__)) [140371243499696] >>> import

[issue5084] unpickling does not intern attribute names

Antoine Pitrou added the comment: In your patch, I'm not sure where the `name` variable is coming from. Have you checked it works? ___ Python tracker ___ _

[issue5084] unpickling does not intern attribute names

Antoine Pitrou added the comment: The test should check that the unpickled strings have been interned. ___ Python tracker ___ ___ Python-bugs-l

[issue5084] unpickling does not intern attribute names

Jake McGuire added the comment: The fromstring/asstring dance was due to my incomplete understanding of refcounting. PyDict_Next returns a borrowed reference but PyString_InternInPlace expects an owned reference. Thanks to Kirk McDonald, I have a new patch that does the refcounting correctl

[issue5084] unpickling does not intern attribute names

Changes by Collin Winter : -- nosy: +collinwinter, jyasskin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue5084] unpickling does not intern attribute names

Antoine Pitrou added the comment: Why do you call PyString_AsString() followed by PyString_FromString()? Strings are immutable so you shouldn't neek to take a copy. Besides, it would be nice to add a test. -- nosy: +pitrou ___ Python tracker

[issue5084] unpickling does not intern attribute names

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue5084] unpickling does not intern attribute names

Alexandre Vassalotti added the comment: Oh, you are right. I was looking at py3k's version of pickle, which uses PyDict_Update instead of a while loop; that is why I got confused. ___ Python tracker

[issue5084] unpickling does not intern attribute names

Jake McGuire added the comment: Are you sure? I may not have enough context in my diff, which I should have done against an anonymous svn checkout, but it looks like the slot attributes get set several lines after my diff. "while (PyDict_Next(slotstate, ...))" as opposed to the "while

[issue5084] unpickling does not intern attribute names

Alexandre Vassalotti added the comment: The patch for cPickle doesn't do the same thing as the pickle one. In the cPickle one, you are only interning slot attributes, which, I believe, is not what you intended. :-) -- assignee: -> alexandre.vassalotti nosy: +alexandre.vassalotti _

[issue5084] unpickling does not intern attribute names

Changes by Jake McGuire : Added file: http://bugs.python.org/file12882/cPickle.c.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue5084] unpickling does not intern attribute names

Changes by Jake McGuire : Removed file: http://bugs.python.org/file12879/cPickle.c.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue5084] unpickling does not intern attribute names

Gabriel Genellina added the comment: Either my browser got crazy, or you uploaded the same patch (.py) twice. -- nosy: +gagenellina ___ Python tracker ___ ___

[issue5084] unpickling does not intern attribute names

Changes by Jake McGuire : Added file: http://bugs.python.org/file12880/pickle.py.diff ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue5084] unpickling does not intern attribute names

New submission from Jake McGuire : Instance attribute names are normally interned - this is done in PyObject_SetAttr (among other places). Unpickling (in pickle and cPickle) directly updates __dict__ on the instance object. This bypasses the interning so you end up with many copies of the st