Jack Diederich jackd...@gmail.com added the comment:
between r71434 and r74217 this should be fixed for 3.2.
Marking as closed.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5188
LazyLogik naimesh.thak...@gmail.com added the comment:
Hello,
I am also facing problems in using telnetlib.
I think following changes are also required. e.g. on line 442 (if c!=
IAC) should be replaced with (if c!= IAC[0]). Similarly line 465 (if cmd
in (DO, DONT)) should be replaced with
Jack Diederich jackd...@gmail.com added the comment:
I assigned this to me. I'll be sprinting on telnetlib.
--
assignee: - jackdied
nosy: +jackdied
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5188
Changes by STINNER Victor victor.stin...@haypocalc.com:
--
nosy: -haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5188
___
___
David Christian d...@rpath.com added the comment:
True. It turns out that there are other uses of a bytes string when a
byte is required in that same routine. I've patched up those as well.
Looks what we really need is a test of this function. I'll work on that
as well.
Changes by David Christian d...@rpath.com:
Added file: http://bugs.python.org/file13099/telnetlib.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5188
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
b\021[0] can be written 0o21 (or 17 or 0x11).
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5188
___
Changes by David Christian d...@rpath.com:
--
keywords: +patch
Added file: http://bugs.python.org/file13062/telnetlib.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5188
___
New submission from David Christian d...@rpath.com:
in telnetlib's process_rawq, rawq_getchar() returns a bytes object of
length 1.
However, that buffer is then compared directly against the variable IAC,
which is the integer 255. This is always false, as bytes([255]) != 255.
Checked svn and
David Christian d...@rpath.com added the comment:
The result of this bug is that any callback set via
set_option_negotiation_callback will not be called.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5188
10 matches
Mail list logo