[issue5273] 3.0.1 crashes in unicode path

Changes by Martin v. Löwis : -- priority: -> normal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue5273] 3.0.1 crashes in unicode path

Hirokazu Yamamoto added the comment: Thanks, fixed in r70157(py3k) and r70158(release30-maint) -- priority: release blocker -> resolution: -> fixed status: open -> closed ___ Python tracker __

[issue5273] 3.0.1 crashes in unicode path

Antoine Pitrou added the comment: I cannot say anything except that the patch looks ok. If it doesn't make anything worse and solves the present problem, I guess you can commit it. ___ Python tracker ___

[issue5273] 3.0.1 crashes in unicode path

Changes by Hirokazu Yamamoto : -- priority: -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5273] 3.0.1 crashes in unicode path

Changes by Hirokazu Yamamoto : Removed file: http://bugs.python.org/file13098/fix_import.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue5273] 3.0.1 crashes in unicode path

Hirokazu Yamamoto added the comment: >Should PyUnicode_CompareWithASCIIString() be replaced with something >else as well? I hope revised patch will fix this too. There seems to be no function to compare unicode object and file system encoded string, so I moved unicode creation before comparatio

[issue5273] 3.0.1 crashes in unicode path

Hirokazu Yamamoto added the comment: I tracked down, and I found this mbcs path is set in Python/import.c(1394) find_module. if (PyUnicode_Check(v)) { v = PyUnicode_AsEncodedString(v, Py_FileSystemDefaultEncoding, NULL); if (v == NUL

[issue5273] 3.0.1 crashes in unicode path

Hirokazu Yamamoto added the comment: I'm not sure. Even my patch might not be correct anyway. On my VC6 Debugger, update_compiled_module(PyCodeObject *co, char *pathname) pathname is surely mbcs. But its caller load_source_module is calling if (fstat(fileno(fp), &st) != 0) {

[issue5273] 3.0.1 crashes in unicode path

Antoine Pitrou added the comment: Gasp. Sorry for the bug. Should PyUnicode_CompareWithASCIIString() be replaced with something else as well? -- nosy: +pitrou ___ Python tracker

[issue5273] 3.0.1 crashes in unicode path

Hirokazu Yamamoto added the comment: Here is a patch. -- components: +Interpreter Core, Unicode keywords: +patch versions: +Python 3.1 Added file: http://bugs.python.org/file13098/fix_import.patch ___ Python tracker

[issue5273] 3.0.1 crashes in unicode path

Hirokazu Yamamoto added the comment: Quick observation. This bug was introduces in r68363. import.c(994) newname = PyUnicode_FromString(pathname); pathname is mbcs on windows, but PyUnicode_FromString assumes it as UTF8. -- nosy: +ocean-city __

[issue5273] 3.0.1 crashes in unicode path

New submission from Musashi Tamura : In unicode path Python 3.0.1 crashes when importing compiled module. This does not happen on Python 3.0, new in 3.0.1. Detailed Situation: OS: win2000 current pathname contains Japanese characters. ./a.py contains only a statement "import b". ./b.py is empty.