[issue5311] bdist_msi generates version number for pure Python packages

New submission from Steven Bethard : I just ran "setup.py bdist_msi" with NLTK which is a pure Python package. You can see the setup.py here: http://code.google.com/p/nltk/source/browse/trunk/nltk/setup.py. Despite the fact that NLTK is pure Python, the generated .msi's look like nltk-0.9.8.win32

[issue5311] bdist_msi generates version number for pure Python packages

Martin v. Löwis added the comment: > So, two questions: (1) are the version numbers supposed to be there? Yes. > (2) if so, does that mean a .msi for a pure Python package built by > Python 2.6 won't work on any other version? Yes. -- nosy: +loewis __

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: Mostly out of curiosity, why is that? With bdist_wininst, a pure Python package would generate a version-less installer that could then be used with any Python version. ___ Python tracker _

[issue5311] bdist_msi generates version number for pure Python packages

Martin v. Löwis added the comment: > Mostly out of curiosity, why is that? Primarily because it's not implemented. To implement it, you would need to collect all Python installations on the system from the registry, then create a UI to let the user select a specific installation, then use that.

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: I'm certainly no Windows API expert, but if no one takes a stab at it sooner, maybe I can spend some time looking at this during PyCon. I'm switching the ticket type to a feature request. -- type: behavior -> feature request __

[issue5311] bdist_msi generates version number for pure Python packages

Changes by Tarek Ziadé : -- versions: +Python 2.7, Python 3.1 -Python 2.5, Python 2.6 ___ Python tracker ___ ___ Python-bugs-list maili

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: Ok, so here's what needs to happen to make this work. Note that all of the following needs to happen at *runtime*, not at the time at which the .msi is created: (1) Find all sub-keys of SOFTWARE\Python\PythonCore in the registry. These are the versions, e.g. 2.

[issue5311] bdist_msi generates version number for pure Python packages

Martin v. Löwis added the comment: In http://www.installsite.org/pages/en/msi/articles/MultiListBox/index.htm there is a demo how to modify the listbox contents dynamically using VBScript. -- ___ Python tracker

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: Thanks for the link. I did play around with that code for quite a while, and while I'm convinced there's a way to get it to work, I'm still struggling with it. I believe the attached .vbs file does about what we need to do, but I think I'm attaching it at the wr

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: My OpenView bug was just a missing "Set". The CustomAction does seem to be correctly gathering the Python paths from the registry and filling the ListView now. I've still got a couple of errors showing up later in the process, but I expect I'll probably have a p

[issue5311] bdist_msi generates version number for pure Python packages

Changes by Steven Bethard : Removed file: http://bugs.python.org/file13536/PythonVersions.vbs ___ Python tracker ___ ___ Python-bugs-list maili

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: Ok, I've made some progress on this. The attached patch now generates MSIs which are version agnostic and look up the appropriate Python version in the registry. Some things still remaining to do: * The ProductName needs to be modified at runtime to prefix the

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: I'm still stuck on getting the right name to show up in ARP. Another problem: it seems like we have to update the ProductCode at runtime as well - otherwise, you can only have one module installed for all the versions of Python you have on your machine. But if

[issue5311] bdist_msi generates version number for pure Python packages

Changes by Steven Bethard : Removed file: http://bugs.python.org/file13649/bdist_msi.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: Updated the patch to make sure ProductName is set before ValidateProductID. -- Added file: http://bugs.python.org/file13823/bdist_msi.patch ___ Python tracker _

[issue5311] bdist_msi generates version number for pure Python packages

Martin v. Löwis added the comment: > I'm still stuck on getting the right name to show up in ARP. It may that indeed Installer blocks the property from being passed onto the server side. Three things to try: - inspect the log file, to see whether it is passed, and then whether it gets set. Yo

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: Ok, I've been chatting with folks on microsoft.public.platformsdk.msi, and I think the right approach here is to define a Feature for each version of Python. Each Feature would install the exact same files, but to a different Python directory. One of the nice t

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: Ok, that was actually easier than I thought it would be. The new patch introduces properties for each Python version (e.g. TARGETDIR2.4, PYTHON.MACHINE.2.4, etc.), and disables and hides the features for any Python versions that aren't found in the registry. Th

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: Ok, I added one final Feature that allows the user to specify an alternate Python directory. (The PathEdit for specifying the directory will only display if this Feature is set to be installed.) I think this patch is pretty much ready to go in now. It could use

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: A slightly improved patch, using DuplicateFile instead of storing a copy of each file for each Python version. Should keep the size of the resulting MSI similar to the size of the currently generated MSIs. -- Added file: http://bugs.python.org/file13854

[issue5311] bdist_msi generates version number for pure Python packages

Changes by Steven Bethard : Removed file: http://bugs.python.org/file13847/bdist_msi.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: Ok, one last tiny update that makes sure TARGETDIR is always set to one of the TARGETDIRX.Ys from a Feature that is actually selected. I swear I'm done with this now. ;-) -- Added file: http://bugs.python.org/file13855/bdist_msi.patch

[issue5311] bdist_msi generates version number for pure Python packages

Changes by Steven Bethard : Removed file: http://bugs.python.org/file13854/bdist_msi.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue5311] bdist_msi generates version number for pure Python packages

Martin v. Löwis added the comment: Can you kindly attach a demo MSI, to simplify review? -- ___ Python tracker ___ ___ Python-bugs-lis

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: Here's an MSI generated for the argparse module. -- Added file: http://bugs.python.org/file13856/argparse-0.9.1.win32.msi ___ Python tracker ___

[issue5311] bdist_msi generates version number for pure Python packages

Martin v. Löwis added the comment: The patch looks fine so far, please apply to trunk and 3k. As this is a new feature, I think backporting it is not appropriate. I believe that the support for (pre)install scripts is incorrect; I would expect that each such script should be executed once per v

[issue5311] bdist_msi generates version number for pure Python packages

Anthony Tuininga added the comment: One additional suggestion: allow the packager to specify what the minimum Python version is. Otherwise, you might have a package that enables installation for Python 2.3 and 2.4 when the maintainer has already stated that Python 2.5 is the minimum version supp

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: @martin: Thanks! Do I need to do something special to make the merging work right? Or do I just apply the patch separately to the trunk and the py3k branche? Good point about the install script - I think the condition needs to be ("&Python%s=3" % ver) instead

[issue5311] bdist_msi generates version number for pure Python packages

Anthony Tuininga added the comment: I've created another feature request as requested for supplying a minimum Python version when creating pure Python packages. http://bugs.python.org/issue5926 -- ___ Python tracker

[issue5311] bdist_msi generates version number for pure Python packages

Martin v. Löwis added the comment: > Thanks! Do I need to do something special to make the merging work > right? Or do I just apply the patch separately to the trunk and the py3k > branche? You commit to the trunk, then you do "svnmerge merge -r" in the 3k branch, then "svn commit -F svnmerge-s

[issue5311] bdist_msi generates version number for pure Python packages

Steven Bethard added the comment: > You commit to the trunk, then you do "svnmerge merge -r" in the > 3k branch, then "svn commit -F svnmerge-something.txt" (in case of > conflicts, you fix them first, of course). Done in r72306 for trunk and r72309 for 3k. Thanks. > I'm not sure - I think th