[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Changes by Jesse Noller jnol...@gmail.com: Removed file: http://bugs.python.org/file14319/stdin-patchv1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5313 ___

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Changes by Jesse Noller jnol...@gmail.com: Removed file: http://bugs.python.org/file14320/0001-Fix-issue-5313.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5313 ___

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Jesse Noller jnol...@gmail.com added the comment: Committed in r73708 on trunk -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5313 ___

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Jesse Noller jnol...@gmail.com added the comment: Attached is a patch with docs, tests and the fix as suggested by OG7 (whom I can't add to the ACKS without a real name). Please check the additional doc note I added to the all platforms programming guidelines. -- Added file:

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Jesse Noller jnol...@gmail.com added the comment: Attached is a patch which calls close() first, and then attempts to close the fd. In the case of an attribute errors (fileno doesn't exist) we simply set it to devnull. This is just a thought, feedback welcome - right now this allows this

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

OG7 ony...@users.sourceforge.net added the comment: Please do this: --- a/multiprocessing/process.py +++ b/multiprocessing/process.py @@ -225,7 +225,8 @@ class Process(object): self._children = set() self._counter = itertools.count(1) try: -

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Jesse Noller jnol...@gmail.com added the comment: On Fri, Jun 19, 2009 at 11:55 AM, OG7rep...@bugs.python.org wrote: OG7 ony...@users.sourceforge.net added the comment: One shouldn't close the fileno after the file has been closed. The stdlib raises an error, and the open(os.devnull) won't

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

OG7 ony...@users.sourceforge.net added the comment: Using sys.stdin.close() fixes issues 5155 and 5331. -- nosy: +OG7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5313 ___

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Graham Dumpleton graham.dumple...@gmail.com added the comment: Worth noting is that Python documentation in: http://docs.python.org/library/stdtypes.html says: file.fileno() Return the integer “file descriptor” that is used by the underlying implementation to request I/O operations from the

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Pablo Torres Navarrete tn.pa...@gmail.com added the comment: Wouldn't it be more pythonic to just try sys.stdin.fileno() and catch the AtributeError too? def _bootstrap(self): try: os.close(sys.stdin.fileno()) except AtributeError:

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

OG7 ony...@users.sourceforge.net added the comment: Closing the stdin fd without closing the stdin file is very dangerous. It means that stdin will now access some random resource, for example, a pipe created with os.pipe(). Closing stdin is useful to let the parent be alone in reading from it.

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Marcin Cieslik marcin.cies...@gmail.com added the comment: Hello, I believe I am the edge-case. I've written a minimalist python Tkinter-shell around Tkinter.Text and code.InteractiveConsole by hi-jacking stdin, stdout and stderr. It hangs when using multiprocessing pool. to reproduce run

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Changes by Jesse Noller jnol...@gmail.com: -- priority: - low ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5313 ___ ___ Python-bugs-list mailing

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Jesse Noller jnol...@gmail.com added the comment: Joshua Judson Rosen to python-list Jesse Noller jnol...@gmail.com writes: On Tue, Feb 17, 2009 at 10:34 PM, Graham Dumpleton graham.dumple...@gmail.com wrote: Why is the multiprocessing module, ie.,

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

Changes by Jesse Noller jnol...@gmail.com: -- assignee: - jnoller ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5313 ___ ___ Python-bugs-list

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

New submission from Graham Dumpleton graham.dumple...@gmail.com: In multiprocessing.process it contains the code: def _bootstrap(self): if sys.stdin is not None: try: os.close(sys.stdin.fileno()) except (OSError,