[issue5630] Create alternative CObject API that is safe and clean

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue5630] Create alternative CObject API that is safe and clean

Benjamin Peterson added the comment: Applied in r72363. -- nosy: +benjamin.peterson resolution: -> accepted status: open -> closed ___ Python tracker ___ ___

[issue5630] Create alternative CObject API that is safe and clean

Larry Hastings added the comment: A nice fresh patch, against r72309. Incorporates changes based on Benjamin's latest batch of Rietveld comments. They're thinning out, so we must be near the end--and with a day to spare. Also strips out almost-all documentation from "pycapsule.h". Note: this

[issue5630] Create alternative CObject API that is safe and clean

Larry Hastings added the comment: dalcinl: Thanks, I've fixed the doc wrt writing "int" where I meant "void *". As for using "disambiguate" in many places: there are a couple of sentences that are repeated in the documentation for several functions. Those repeated sentences all use "ambiguous"

[issue5630] Create alternative CObject API that is safe and clean

Lisandro Dalcin added the comment: In Doc/c-api/capsule.rst, you wrote .. cfunction:: int PyCapsule_Import(const char* name, int no_block) but it should be: .. cfunction:: void* PyCapsule_Import(const char* name, int no_block) Additionally, you wrote "disambugate" in many places. --

[issue5630] Create alternative CObject API that is safe and clean

Larry Hastings added the comment: Updated patch based on impressively thorough Rietveld feedback from Benjamin Peterson. Thanks, Benjamin! This patch should not be considered final; we already know the API documentation in the comments in Include/pycapsule.h needs to change (somehow). ---

[issue5630] Create alternative CObject API that is safe and clean

Larry Hastings added the comment: Added a test case for capsules to _testcapimodule.c, and updated to the latest trunk. -- title: Create alternatieve CObject API that is safe and clean -> Create alternative CObject API that is safe and clean Added file: http://bugs.python.org/file13820