Antoine Pitrou pit...@free.fr added the comment:
Thanks!
Committed as r72909 (trunk), r72910 (py3k).
--
resolution: accepted - fixed
status: open - closed
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5670
Collin Winter coll...@gmail.com added the comment:
Fixed the len(d) == 1 size regression. Final performance of the patch
relative to trunk:
Using Unladen Swallow's perf.py -b pickle,pickle_dict on trunk:
pickle:
Min: 2.238 - 1.895: 18.08% faster
Avg: 2.241 - 1.898: 18.04% faster
Significant
Antoine Pitrou pit...@free.fr added the comment:
Sorry, it won't even be integrated in 2.6 actually. It's a new feature,
not a bug fix.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5670
Kelvin Liang lbh1...@gmail.com added the comment:
Can this patch be used or ported to 2.5.x?
--
nosy: +feisan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5670
___
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
Sorry, I was wrong. I think I noticed that the case size==1 was handled
differently, and incorrectly inferred the same for size==0.
(btw, the patch for trunk was not updated)
--
___
Python
Alexandre Vassalotti alexan...@peadrop.com added the comment:
Silly me, I had changed the PyDict_Size call in outer loop for Py_SIZE
and this is of course totally wrong. Here's a good patch (I am pretty
sure now! ;-) I ran the whole test suite and I saw no failures.
Collin, you can go ahead and
Alexandre Vassalotti alexan...@peadrop.com added the comment:
Sigh... silly me again. There is some other junk in my last patch.
--
Added file: http://bugs.python.org/file13598/pickle_batch_dict_exact_py3k-5.diff
___
Python tracker
Changes by Alexandre Vassalotti alexan...@peadrop.com:
Removed file:
http://bugs.python.org/file13596/pickle_batch_dict_exact_py3k-3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5670
___
Changes by Alexandre Vassalotti alexan...@peadrop.com:
Removed file:
http://bugs.python.org/file13597/pickle_batch_dict_exact_py3k-4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5670
___
Collin Winter coll...@gmail.com added the comment:
FYI, I just added a pickle_dict microbenchmark to perf.py. Using this
new microbenchmark, I see these results (perf.py -r -b pickle_dict):
pickle_dict:
Min: 2.092 - 1.341: 56.04% faster
Avg: 2.126 - 1.360: 56.37% faster
Significant
Collin Winter coll...@gmail.com added the comment:
Amaury, I can't reproduce the issue you're seeing with empty dicts.
Here's what I'm doing:
dhcp-172-19-19-199:trunk collinwinter$ ./python.exe
Python 2.7a0 (trunk:71100M, Apr 3 2009, 14:40:49)
[GCC 4.0.1 (Apple Inc. build 5490)] on darwin
New submission from Collin Winter coll...@gmail.com:
The attached patch adds another version of cPickle.c's batch_dict(),
batch_dict_exact(), which is specialized for type(x) is dict. This
provides a nice performance boost when pickling objects that use
dictionaries:
Pickle:
Min: 2.216 - 1.858:
Antoine Pitrou pit...@free.fr added the comment:
Without taking a very detailed look, the patch looks good.
Are there already tests for pickling of dict subclasses? Otherwise, they
should be added.
--
nosy: +pitrou
___
Python tracker
Antoine Pitrou pit...@free.fr added the comment:
By the way, could the same approach be applied to lists and sets as well?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5670
___
Collin Winter coll...@gmail.com added the comment:
On Thu, Apr 2, 2009 at 12:20 PM, Antoine Pitrou rep...@bugs.python.org wrote:
Antoine Pitrou pit...@free.fr added the comment:
By the way, could the same approach be applied to lists and sets as well?
Certainly; see
Antoine Pitrou pit...@free.fr added the comment:
Certainly; see http://bugs.python.org/issue5671 for the list version.
It doesn't make as big an impact on the benchmark, though.
How about splitting the benchmark in parts:
- (un)pickling lists
- (un)pickling dicts
- (un)pickling sets
(etc.)
Collin Winter coll...@gmail.com added the comment:
Antoine: pickletester.py:test_newobj_generic() appears to test dict
subclasses, though in a roundabout-ish way. I don't know of any tests
for dict subclasses in the C level sense (ie, PyDict_Check() vs
PyDict_CheckExact()). I can add more
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
The patch produces different output for an empty dict: a sequence MARK
SETITEMS is written, which is useless and wastes 2 bytes.
--
nosy: +amaury.forgeotdarc
___
Python tracker
Antoine Pitrou pit...@free.fr added the comment:
Antoine: pickletester.py:test_newobj_generic() appears to test dict
subclasses, though in a roundabout-ish way. I don't know of any tests
for dict subclasses in the C level sense (ie, PyDict_Check() vs
PyDict_CheckExact()). I can add more
Alexandre Vassalotti alexan...@peadrop.com added the comment:
I ported the patch to py3k. In addition, I added a special-case when the
dict contains only one item; you probably want this special-case in the
trunk version as well.
--
nosy: +alexandre.vassalotti
Added file:
Alexandre Vassalotti alexan...@peadrop.com added the comment:
Oops, I forgot to add the comment on top of batch_dict_exact in the
patch. Here is a better patch.
--
Added file: http://bugs.python.org/file13594/pickle_batch_dict_exact_py3k-2.diff
___
Alexandre Vassalotti alexan...@peadrop.com added the comment:
Oops again, I just remarked that the comment for batch_dict_exact refers
to batch_dict as being above, but I copied batch_dict_exact before
batch_dict. Here's a good patch (hopefully) that puts batch_dict_exact
at the right place.
Changes by Alexandre Vassalotti alexan...@peadrop.com:
Removed file: http://bugs.python.org/file13593/pickle_batch_dict_exact_py3k.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5670
___
Changes by Alexandre Vassalotti alexan...@peadrop.com:
Removed file:
http://bugs.python.org/file13594/pickle_batch_dict_exact_py3k-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5670
___
24 matches
Mail list logo
