Antoine Pitrou pit...@free.fr added the comment:
You should commit. If there is a problem with other Windows build files,
it will certainly be noticed and fixed by a true Windows developer.
--
___
Python tracker rep...@bugs.python.org
Alexandre Vassalotti alexan...@peadrop.com added the comment:
Committed in r71185.
Thanks Antoine for the review!
--
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5682
New submission from Alexandre Vassalotti alexan...@peadrop.com:
Here is a patch that moves the source files of the _io module (and
closely related modules) into subdirectory of Modules. The new file
hierarchy proposed is the following:
Modules/
_io/
_iomodule.h
_iomodule.c
Antoine Pitrou pit...@free.fr added the comment:
Where's the patch?
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5682
___
___
Changes by Alexandre Vassalotti alexan...@peadrop.com:
Added file: http://bugs.python.org/file13602/move-iomodule-in-subdir.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5682
___
Antoine Pitrou pit...@free.fr added the comment:
Some comments:
- there are some unrelated pickle changes in your patch
- in Makefile.pre.in, it seems the IO_OBJS definition might need updating
Otherwise I don't have any objections.
Please note, when committing, it would be good to use svn mv
Alexandre Vassalotti alexan...@peadrop.com added the comment:
Antoine, you're too quick. :-)
By the way, the patch is fairly large due to the renaming. So, here's
quick-and-dirty summary of the important changes.
PCbuild/pythoncore.vcproj: Renamed the paths and added a Filter/ tag
for the
Alexandre Vassalotti alexan...@peadrop.com added the comment:
Antoine wrote:
- in Makefile.pre.in, it seems the IO_OBJS definition might need updating
I updated the patch to also fix IO_OBJS. Also, I added stringio.c to
IO_OBJS.
Please note, when committing, it would be good to use svn mv
Changes by Alexandre Vassalotti alexan...@peadrop.com:
Removed file: http://bugs.python.org/file13602/move-iomodule-in-subdir.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5682
___
Changes by Alexandre Vassalotti alexan...@peadrop.com:
Removed file: http://bugs.python.org/file13604/move-iomodule-in-subdir-2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5682
___
Antoine Pitrou pit...@free.fr added the comment:
I think you can commit!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5682
___
___
Alexandre Vassalotti alexan...@peadrop.com added the comment:
Have you tested PCbuild changes? As, this is the part I am the most
unsure about.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5682
Antoine Pitrou pit...@free.fr added the comment:
Have you tested PCbuild changes? As, this is the part I am the most
unsure about.
Ok, unless someone beats me to it, I'm gonna fire a Windows VM and test
this.
--
___
Python tracker
Antoine Pitrou pit...@free.fr added the comment:
Some failures:
_iomodule.c
c1 : fatal error C1083: Impossible d'ouvrir le fichier source :
'..\..\Modules\_io\_iomodule.c' : No such file or directory
textio.c
c1 : fatal error C1083: Impossible d'ouvrir le fichier source :
Antoine Pitrou pit...@free.fr added the comment:
Or perhaps these are really meant as the new file names? Initially I
thought the purpose was initially to move the files into a subdir.
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou pit...@free.fr added the comment:
After also renaming the files, there is a slight bug in
PCbuild/pythoncore.vcproj. Here is a subpatch incorporating the changes
to this only file.
--
Added file: http://bugs.python.org/file13606/pythoncore.patch
Alexandre Vassalotti alexan...@peadrop.com added the comment:
Thanks! Here is the updated patch.
--
Added file: http://bugs.python.org/file13607/move-iomodule-in-subdir-4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5682
17 matches
Mail list logo
