Antoine Pitrou pit...@free.fr added the comment:
I've uploaded the patch for code review here:
http://codereview.appspot.com/40126
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5734
___
New submission from Brian Quinlan br...@sweetapp.com:
The C implementation:
- doesn't correctly initialize its reader and writer instances
- incorrectly maps its readinto method to another class
- incorrectly delegates its closed property to its base class
i.e. this class can't be used at all
Changes by Brian Quinlan br...@sweetapp.com:
--
components: +Library (Lib)
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5734
___
Antoine Pitrou pit...@free.fr added the comment:
Hey, thanks a lot for caring. I'll take a look at the patch and come
back later.
If you want to add some more tests, you are welcome too :-)
--
assignee: - pitrou
nosy: +pitrou
priority: - release blocker
stage: - patch review
Brian Quinlan br...@sweetapp.com added the comment:
Hey Antoine,
Will do - but first I'll finish up my reason for needing a working
version of this class in the first place ;-)
Cheers,
Brian
--
___
Python tracker rep...@bugs.python.org