[issue5734] Fix BufferedRWPair

2009-04-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Committed in r71736. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker ___

[issue5734] Fix BufferedRWPair

2009-04-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: The patch looks ok, thanks. -- resolution: -> accepted stage: patch review -> commit review ___ Python tracker ___

[issue5734] Fix BufferedRWPair

2009-04-18 Thread Brian Quinlan
Brian Quinlan added the comment: http://codereview.appspot.com/40126/diff/1/2 File Lib/_pyio.py (left): http://codereview.appspot.com/40126/diff/1/2#oldcode370 Line 370: def _checkReadable(self, msg=None): On 2009/04/17 21:11:15, Antoine Pitrou wrote: > Not sure why you're removing it. Currentl

[issue5734] Fix BufferedRWPair

2009-04-18 Thread Brian Quinlan
Changes by Brian Quinlan : Added file: http://bugs.python.org/file13716/rwpair2.diff ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue5734] Fix BufferedRWPair

2009-04-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: Reviewers: report_bugs.python.org, Message: Here are some comments. In general, I think the changes to _pyio.py are unwarranted (even though I dislike the naming of _checkReadable and _checkWritable). http://codereview.appspot.com/40126/diff/1/2 File Lib/_pyio