[issue5940] Wrong type check in check_library_list

2009-05-06 Thread Tarek Ziadé
Tarek Ziadé ziade.ta...@gmail.com added the comment: fixed in r72379 Thanks David ! Notice that this bug exists in Python 3.0 too unfortunately. So I have applied the fix in the 3.0 release branch as well (r72380) -- status: open - closed ___

[issue5940] Wrong type check in check_library_list

2009-05-05 Thread Cournapeau David
New submission from Cournapeau David da...@ar.media.kyoto-u.ac.jp: There is a bug in the function check_library_list. Assuming there are some libraries in the distribution instance, the function checks that lib[0] is a string, but the test checks exactly the contrary (line 137 of build_clib.py).

[issue5940] Wrong type check in check_library_list

2009-05-05 Thread Tarek Ziadé
Tarek Ziadé ziade.ta...@gmail.com added the comment: Good catch ! Obviously this was introduced when the Python 2 version was refactored for Python 3 (in python 2 its if type(lib[0]) is not StringType) I shall fix this today or tonite (I need to add test coverage for this command) --