[issue5950] Make zipimport work with zipfile containing comments

Barry A. Warsaw added the comment: New changeset 5a5ce064b3baadcb79605c5a42ee3d0aee57cdfc by Barry Warsaw (Zackery Spytz) in branch 'master': bpo-5950: Support reading zips with comments in zipimport (#9548) https://github.com/python/cpython/commit/5a5ce064b3baadcb79605c5a42ee3d0aee57cdfc

[issue5950] Make zipimport work with zipfile containing comments

Change by Barry A. Warsaw : -- components: +Library (Lib) -Interpreter Core resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue5950] Make zipimport work with zipfile containing comments

Zackery Spytz added the comment: I've created a PR. -- nosy: +ZackerySpytz versions: +Python 3.8 -Python 3.6 ___ Python tracker ___

[issue5950] Make zipimport work with zipfile containing comments

Change by Zackery Spytz : -- pull_requests: +8951 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5950] Make zipimport work with zipfile containing comments

Serhiy Storchaka added the comment: It is not fixed yet. But it is now easier to fix. -- ___ Python tracker ___ ___

[issue5950] Make zipimport work with zipfile containing comments

Dima Tisnek added the comment: Very glad to hear! Let's document what Python version(s) are "fixed". Perhaps this issue deserves a test case in issue25711. -- ___ Python tracker

[issue5950] Make zipimport work with zipfile containing comments

Serhiy Storchaka added the comment: zipimport have been rewritten in pure Python (issue25711). -- ___ Python tracker ___ ___

[issue5950] Make zipimport work with zipfile containing comments

Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +superluser versions: +Python 3.6 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5950 ___

[issue5950] Make zipimport work with zipfile containing comments

Serhiy Storchaka added the comment: See issue22322 for yet one use case (git archive creates ZIP file with archive comment). -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5950

[issue5950] Make zipimport work with zipfile containing comments

Thomas Heller added the comment: As for progress, the answer is no as the hope is to eventually replace zipimport with something in pure Python thanks to importlib. Does this mean there is no chance to put this into 3.4 and 3.3, do we really have to wait until 3.5 with it's pure-python

[issue5950] Make zipimport work with zipfile containing comments

Brett Cannon added the comment: I actually stopped development of a pure Python zip importer so it won't be in Python 3.5 either (http://bugs.python.org/issue17630). The motivation simply wasn't there if zipimport is going to be sticking around for bootstrapping reasons. This can still get

[issue5950] Make zipimport work with zipfile containing comments

Changes by Peter Otten __pete...@web.de: -- nosy: +peter.otten ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5950 ___ ___ Python-bugs-list mailing

[issue5950] Make zipimport work with zipfile containing comments

Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5950 ___ ___ Python-bugs-list

[issue5950] Make zipimport work with zipfile containing comments

Brett Cannon added the comment: This is a feature request so it won't change in Python 2.7. As for progress, the answer is no as the hope is to eventually replace zipimport with something in pure Python thanks to importlib. -- versions: +Python 3.4 -Python 2.7, Python 3.3

[issue5950] Make zipimport work with zipfile containing comments

Dima Tisnek added the comment: also applies to 2.7 series over a year passed since last comment, any progress on this? I just ran into this issue myself. zipfile module handles commented zip's fine, but zipimport doesn't. I didn't expect a gotcha like this from Python! -- nosy:

[issue5950] Make zipimport work with zipfile containing comments

engelbert gruber grub...@users.sourceforge.net added the comment: +1*4 -- nosy: +grubert ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5950 ___

[issue5950] Make zipimport work with zipfile containing comments

Terry J. Reedy tjre...@udel.edu added the comment: Brett, Nick, this could be considered a patch to the import machinery as the bugs shows with a import statement. In any case, no one is signed up for zipimport specifically. -- nosy: +brett.cannon, ncoghlan versions: +Python 3.3

[issue5950] Make zipimport work with zipfile containing comments

Terry J. Reedy tjre...@udel.edu added the comment: I believe this is covered by the PEP3003 3.2 change moratorium. -- versions: +Python 3.3 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5950

[issue5950] Make zipimport work with zipfile containing comments

Georg Brandl ge...@python.org added the comment: Why? -- versions: +Python 3.2 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5950 ___

[issue5950] Make zipimport work with zipfile containing comments

Terry J. Reedy tjre...@udel.edu added the comment: Because it adds a feature to the import statement, rather than to a module, or so Dmitry said. But fine with me if it goes in now. -- stage: - patch review ___ Python tracker rep...@bugs.python.org

[issue5950] Make zipimport work with zipfile containing comments

Terry J. Reedy tjre...@udel.edu added the comment: On #1644818, Brett said import statement is exempt from moratorium. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5950 ___

[issue5950] Make zipimport work with zipfile containing comments

Ryan Kelly r...@rfk.id.au added the comment: I can't imagine anyone depending on this lack-of-feature, but there's no arguing with the technicality of it. One more small incentive to make the jump to Python 3 then. Anyway, I've revisited the patch to clean up the logic and control flow, and

[issue5950] Make zipimport work with zipfile containing comments

Changes by Ryan Kelly r...@rfk.id.au: Removed file: http://bugs.python.org/file17944/zipimport_with_comments.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5950 ___

[issue5950] Make zipimport work with zipfile containing comments

Terry J. Reedy tjre...@udel.edu added the comment: I can't imagine anyone depending on this lack-of-feature, Neither can I, but I can imaging someone writing code that depended on the feature. If added to 3.1.3, then code that depended on it would not run on 3.1, 3.1.1, and 3.1.2. The same is

[issue5950] Make zipimport work with zipfile containing comments

Changes by Georg Brandl ge...@python.org: -- title: Make zimport work with zipfile containing comments - Make zipimport work with zipfile containing comments ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5950

[issue5950] Make zipimport work with zipfile containing comments

Terry J. Reedy tjre...@udel.edu added the comment: the line from the docs about comments not being supported. answers your question. Current behavior is documented behavior and therefor changing it is not a bugfix. -- ___ Python tracker